feat(helmet): implement CSP policy #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a9f62df.
- Loosen CSP policy to allow inline styles, data blob images - Trim unused embedded JavaScript in 404 page - Rework gtag.js and transition page to bind the click handler at runtime as opposed to inlining it, to comply with CSP - Limit bodyParser to JSON, since sentry is handling CSP reports
LoneRifle
force-pushed
the
feat/helmet/csp
branch
from
54e141b to
6fada15
Compare
|
you can introduce a nonce, but you need to somehow modify webpack's output so that Express can dynamically inject the nonce into the bundle. For reference, @isomerpages allows |
liangyuanruo
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #291
Solution
runtime as opposed to inlining it, to comply with CSP