Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UserPage table re-design #97

Merged
merged 25 commits into from
May 27, 2020
Merged

UserPage table re-design #97

merged 25 commits into from
May 27, 2020

Conversation

kylerwsm
Copy link
Contributor

@kylerwsm kylerwsm commented May 19, 2020 •
edited
Loading

Problem

  • Revamp the remaining parts of the UserPage to v2.

Segments

  • Build drawer desktop view.
  • Build drawer for mobile view.
  • Build user table for desktop view.
  • Build user table for mobile view.
  • Stitch empty state into user table.
  • Update pre-release checklist.

@kylerwsm kylerwsm changed the title User page table UserPage table re-design May 19, 2020
@kylerwsm
Copy link
Contributor Author

Force pushing to rebase with develop

kylerwsm and others added 16 commits May 21, 2020 00:03
@kylerwsm
changes to acommodate ts and tsx in client files
bb57eb2
@kylerwsm
code refactor
ecf2a3b
@kylerwsm
integrate draft dialog triggered on row click
89ab83d
@kylerwsm
draft full height aligned to left dialog
a2c9d45
@kylerwsm
override dialog paper left margin
f48908b
@kylerwsm
added header, link analytics sections
d9f6de4
@kylerwsm
added more placeholders
3f7a559
@kylerwsm
added trailing button placeholders
9350a88
@kylerwsm
added a custom switch
0b576f5
@kylerwsm
updated the usage of dialog to drawer
f825029
@JasonChong96 @kylerwsm
User Table Revamp partial (#99)
9d46808 
* User table revamp partial

* Fixes

* Fix lint

* Removed unused icons

* Fix alignment of icon
@kylerwsm
Implement Desktop View Drawer for UserPage re-design (#100)
02581b8 
* added tooltip for short link copy

* linked drawer to redux via shortlink helper hook

* added download button and download option menu

* code refactoring

* added qrcode download func to drawer

* code refactor

* renamed dialog to drawer

* converted optional string to nullable string
@kylerwsm
eslint changes and rebase to develop
32b196f
@JasonChong96 @kylerwsm
Fix styling for desktop user page table (#101)
e8186b5
@kylerwsm
Simplification of number formatting with tests included (#102)
b9dbd39 
* migrate kmb number formatter to intl with tests

* removed the use of low supported intl impl
@kylerwsm
Merge branch 'user-page-table' of github.com:opengovsg/GoGovSG into u…
1496108 
…ser-page-table
JasonChong96 and others added 6 commits May 21, 2020 16:22
@JasonChong96
Sorting and Filtering for Mobile and Desktop (#104)
485a92b
@kylerwsm @JasonChong96
Stitch EmptyState to UserPage/UserTable (#105)
0208175 
* code refactor

* integrate draft dialog triggered on row click

* draft full height aligned to left dialog

* override dialog paper left margin

* added header, link analytics sections

* added more placeholders

* added trailing button placeholders

* added a custom switch

* updated the usage of dialog to drawer

* User Table Revamp partial (#99)

* User table revamp partial

* Fixes

* Fix lint

* Removed unused icons

* Fix alignment of icon

* Implement Desktop View Drawer for UserPage re-design (#100)

* added tooltip for short link copy

* linked drawer to redux via shortlink helper hook

* added download button and download option menu

* code refactoring

* added qrcode download func to drawer

* code refactor

* renamed dialog to drawer

* converted optional string to nullable string

* Add mobile and desktop view

* Add test

* Appease coveralls

* refactored client test to its own directory

* stitch empty state

* remove redundant file

* impl url fetching status to fix search debouncing issue

* revert unintended changes

* adjustments to download links button, and seach bar and toolbar responsiveness

* adjusted link count margin

* removed remnants of sanity check

* wipe on log out and new isInitialised user state

Co-authored-by: Jason Chong <35889982+JasonChong96@users.noreply.github.com>
Co-authored-by: JasonChong96 <jasontjakra@gmail.com>
@JasonChong96
Add mobile table header (#109)
13e7668
@kylerwsm
Differentiate links and filter results (#110)
8c7e72f 
* refactor code

* links now showed as results if filtered

* refactored how search bar consumes height hook
@JasonChong96 @kylerwsm
User page table footer (#108)
9926c3d 
* Fix user page footer

* Move styles into its own file

* Make image undraggable

* improved stylings for table footer (#112)

Co-authored-by: Kyler Wong <wsm.kyler@gmail.com>
@JasonChong96
Add mobile view for drawer (#111)
4812afa 
* Add mobile view for drawer

* Fix desktop font

* Make image draggable false

* Address changes

* Fix margin

* Invert breakpoint condition

* Removes access borders on user table

* Fix margins

* Fix borders
kylerwsm and others added 2 commits May 26, 2020 19:56
@kylerwsm
QR code download and drawer tweaks (#116)
5735cce 
* Make QRModal invisible for download

* drawer tweaks
@JasonChong96
User page drawer fixes (#114)
1b5a0cf 
* Add mobile view for drawer

* Fix desktop font

* Make image draggable false

* Address changes

* Fix margin

* Invert breakpoint condition

* Removes access borders on user table

* Fix margins

* Fix borders

* Fix margins

* Hide long url edit on file

* Fix margins

* Fix drawer text align
@kylerwsm kylerwsm marked this pull request as ready for review May 26, 2020 12:36
yong-jie
yong-jie reviewed May 27, 2020
View reviewed changes
.eslintrc.json Show resolved Hide resolved
src/client/components/UserPage/UserLinkTable/ToolBar/LinkCountHeader/index.tsx Outdated Show resolved Hide resolved
src/client/locale/en/translation.ts Outdated Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
@kylerwsm kylerwsm requested a review from yong-jie May 27, 2020 05:27
@kylerwsm
Copy link
Contributor Author

@yong-jie addressed comments, please give it a look again 😁

yong-jie
yong-jie approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@yong-jie yong-jie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yong-jie yong-jie merged commit 2d8fdc5 into develop May 27, 2020
@yong-jie yong-jie deleted the user-page-table branch May 27, 2020 06:33
@snyk-bot snyk-bot mentioned this pull request Apr 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yong-jie yong-jie yong-jie approved these changes

@JasonChong96 JasonChong96 Awaiting requested review from JasonChong96

Assignees

@kylerwsm kylerwsm

@JasonChong96 JasonChong96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylerwsm @yong-jie @JasonChong96