Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OP-1467 Remove refs to file groups + unsafe update #169

Merged
merged 2 commits into from
Jun 12, 2023
Merged

OP-1467 Remove refs to file groups + unsafe update #169

merged 2 commits into from
Jun 12, 2023

Conversation

edarchis
Copy link
Member

IndexesFG is specific to one setup and OPTIMIZE_FOR_SEQUENTIAL_KEY is not available on some versions of MS SQL.

@edarchis
OP-1467 Remove refs to file groups + unsafe update
9939b98 
IndexesFG is specific to one setup and OPTIMIZE_FOR_SEQUENTIAL_KEY is not available on some versions of MS SQL.
hirensoni913
hirensoni913 reviewed Jun 12, 2023
View reviewed changes
Copy link
Contributor

@hirensoni913 hirensoni913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, it's not even right to create those Non-clustered indexes in the script. Whether or not you need to create them is also implementation specific. So I would remove all the index creation scripts.

@edarchis edarchis force-pushed the fix/OP-1467_sql_migration_errors branch from 758b4be to 92e21f4 Compare June 12, 2023 10:05
@delcroip delcroip merged commit 7a3d906 into develop Jun 12, 2023
@delcroip delcroip deleted the fix/OP-1467_sql_migration_errors branch June 12, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirensoni913 hirensoni913 hirensoni913 left review comments

@delcroip delcroip delcroip approved these changes

@dragos-dobre dragos-dobre Awaiting requested review from dragos-dobre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edarchis @delcroip @hirensoni913