[fix #1128] some rollingupdate field can not updated (#1189)

Signed-off-by: liuzhenwei <dui_zhang@163.com>
openkruise · Feb 22, 2023 · 07c51b9 · 07c51b9
1 parent 85a9542
commit 07c51b9
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/apis/apps/defaults/v1beta1.go b/apis/apps/defaults/v1beta1.go
@@ -26,21 +26,19 @@ import (
 	utilpointer "k8s.io/utils/pointer"
 )
 
-// SetDefaults_StatefulSet set default values for StatefulSet.
+// SetDefaultsStatefulSet set default values for StatefulSet.
 func SetDefaultsStatefulSet(obj *v1beta1.StatefulSet, injectTemplateDefaults bool) {
 	if len(obj.Spec.PodManagementPolicy) == 0 {
 		obj.Spec.PodManagementPolicy = appsv1.OrderedReadyPodManagement
 	}
 
 	if obj.Spec.UpdateStrategy.Type == "" {
 		obj.Spec.UpdateStrategy.Type = appsv1.RollingUpdateStatefulSetStrategyType
-
-		// UpdateStrategy.RollingUpdate will take default values below.
-		obj.Spec.UpdateStrategy.RollingUpdate = &v1beta1.RollingUpdateStatefulSetStrategy{}
 	}
 
 	if obj.Spec.UpdateStrategy.Type == appsv1.RollingUpdateStatefulSetStrategyType {
 		if obj.Spec.UpdateStrategy.RollingUpdate == nil {
+			// UpdateStrategy.RollingUpdate will take default values below.
 			obj.Spec.UpdateStrategy.RollingUpdate = &v1beta1.RollingUpdateStatefulSetStrategy{}
 		}
 		if obj.Spec.UpdateStrategy.RollingUpdate.Partition == nil {