Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix #1128] some rollingupdate field can not updated #1189

Conversation

diannaowa
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #1128

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Signed-off-by: liuzhenwei <dui_zhang@163.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1189 (5aeb11d) into master (3d3f51d) will decrease coverage by 0.16%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1189      +/-   ##
==========================================
- Coverage   49.91%   49.76%   -0.16%     
==========================================
  Files         138      138              
  Lines       19495    19554      +59     
==========================================
  Hits         9731     9731              
- Misses       8697     8755      +58     
- Partials     1067     1068       +1     
Flag Coverage Δ
unittests 49.76% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/cloneset/cloneset_event_handler.go 59.34% <0.00%> (-18.73%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zmberg
Copy link
Member

zmberg commented Feb 22, 2023

/lgtm

@zmberg
Copy link
Member

zmberg commented Feb 22, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zmberg zmberg added this to the v1.4 milestone Feb 22, 2023
@kruise-bot kruise-bot merged commit 07c51b9 into openkruise:master Feb 22, 2023
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] some rollingUpdate field can not updated,if the yaml did not set type: RollingUpdate
4 participants