Fix EphemeralJob event handler for deleting object (#1401)

Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
openkruise · Sep 6, 2023 · ebcee23 · ebcee23
1 parent a477df8
commit ebcee23
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/pkg/controller/ephemeraljob/ephemeraljob_event_handler.go b/pkg/controller/ephemeraljob/ephemeraljob_event_handler.go
@@ -97,6 +97,12 @@ func (e *ejobHandler) Update(evt event.UpdateEvent, q workqueue.RateLimitingInte
 		return
 	}
 
+	if curEJob.DeletionTimestamp != nil {
+		klog.V(3).Infof("Observed deleting ephemeral job: %s/%s", curEJob.Namespace, curEJob.Name)
+		q.Add(reconcile.Request{NamespacedName: types.NamespacedName{Namespace: curEJob.Namespace, Name: curEJob.Name}})
+		return
+	}
+
 	// only update these fields
 	if oldEJob.Spec.TTLSecondsAfterFinished != curEJob.Spec.TTLSecondsAfterFinished ||
 		oldEJob.Spec.Paused != curEJob.Spec.Paused || oldEJob.Spec.Parallelism != curEJob.Spec.Parallelism ||