pod probe marker proposal #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmberg
force-pushed
the
pod-probe-maker-proposal
branch
from
3b39850 to
1b5a264
Compare
|
what's the relation between PodProbeMaker probes and the default kubernetes probes?If both set, both will executed? |
furykerry
reviewed
Aug 18, 2022
| # When probe execution is successful | ||
| - probeName: Master | ||
| expectation: succeeded | ||
| labels: |
There was a problem hiding this comment.
plz enumerate possible actions, i think the following action is possible
- patch labels
- patch annotations
- patch readiness gate conditions
furykerry
reviewed
Aug 18, 2022
zmberg
force-pushed
the
pod-probe-maker-proposal
branch
2 times, most recently
from
7c92201 to
dfb274b
Compare
furykerry
reviewed
Aug 24, 2022
| expectation: failed | ||
| labels: | ||
| gameserver-healthy: 'false' | ||
| - probeName: Idle |
There was a problem hiding this comment.
consider more concise form of the probe spec
- probeName: Idle
- condition: succeeded
annotations:
controller.kubernetes.io/pod-deletion-cost: '-1'
- condition: failed
annotations:
controller.kubernetes.io/pod-deletion-cost: '1'
dfb274b to
3518183
Compare
furykerry
reviewed
Aug 25, 2022
| - status: 'True' | ||
| labels: | ||
| gameserver-healthy: 'true' | ||
| - status: 'False' |
There was a problem hiding this comment.
how we ensure conditions True and False both exists, what if one of them(such as False) is not specified, what is the default behavior, clear the annotations?
zmberg
force-pushed
the
pod-probe-maker-proposal
branch
from
3518183 to
9cf27d2
Compare
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
zmberg
force-pushed
the
pod-probe-maker-proposal
branch
from
9cf27d2 to
e27dd6e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
baxiaoshi
pushed a commit
to baxiaoshi/kruise
that referenced
this pull request
Nov 21, 2022
Signed-off-by: peng.xin <peng.xin@ly.com> optimize workloadspread when suitable subset maxReplicas is niil (openkruise#1066) Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Optimize performance of LabelSelector conversion (openkruise#1068) Signed-off-by: FillZpp <FillZpp.pub@gmail.com> Signed-off-by: FillZpp <FillZpp.pub@gmail.com> Support timezone for AdvancedCronJob (openkruise#1070) Signed-off-by: FillZpp <FillZpp.pub@gmail.com> Signed-off-by: FillZpp <FillZpp.pub@gmail.com> ignore if pod condition has been updated (openkruise#1074) Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> pod probe marker apis (openkruise#1073) * pod probe marker apis Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> * fix statefulset truncateHistory panic Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> pod probe marker controller (openkruise#1075) Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> consider whether patch field is matched when assign existing pods to subset (openkruise#1083) Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> pod probe marker webhook (openkruise#1078) Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> sidecarset support pods ns(kube-system, kube-public) (openkruise#1084) Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> pod probe marker proposal (openkruise#1053) Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> node pod probe daemon (openkruise#1077) Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> sidecarset support patch pod metadata proposal (openkruise#993) Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> Support predownload image in ads (openkruise#1057) Signed-off-by: Abner <abner199709@gmail.com> * support predownload image for ads Add PreDownloadImageForDaemonSetUpdate featureGate (openkruise#1093) Signed-off-by: FillZpp <FillZpp.pub@gmail.com> Signed-off-by: FillZpp <FillZpp.pub@gmail.com> Add changelog for v1.3.0 (openkruise#1092) Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> fix sidecarset inject annotations abnormal (openkruise#1101) Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> fix InPlaceUpdateEnvFromMetadata bug (openkruise#1108) Co-authored-by: 郭已钦 <xiangyang2@xiaohongshu.com> support uniteddeployment persistentVolumeClaimRetentionPolicy inherit from advancestatefulset template (openkruise#1110) Signed-off-by: cheyuexian <cheyuexian@bilibili.com> Signed-off-by: cheyuexian <cheyuexian@bilibili.com> Co-authored-by: cheyuexian <cheyuexian@bilibili.com> Add PreNormal Lifecycle Hook for CloneSet (openkruise#1071) * add pre-normal(pre-available) hook Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> * add pre-normal(pre-available) hook Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> partition support float percent (openkruise#1124) Signed-off-by: shiyan2016 <shiyan20160606@gmail.com> Signed-off-by: shiyan2016 <shiyan20160606@gmail.com> improve error hanlding of inplace update env from metadata (openkruise#1125) Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> pub support to configure Evict,Delete,Update Operation (openkruise#1126) Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> feat: add watch whitelist feat: add watch whitelist add watch whitelist check add dynamic watch option feat: add persistent annotations format feat: add pps support custom workload Signed-off-by: peng.xin <peng.xin@ly.com> fix: nodeSelector and nodeAffinity have not been modified Signed-off-by: peng.xin <peng.xin@ly.com> fix: error string Signed-off-by: peng.xin <peng.xin@ly.com> fix: error string Signed-off-by: peng.xin <peng.xin@ly.com> fix: goimports Signed-off-by: peng.xin <peng.xin@ly.com> refactor: refactoring ersistentPodAnnotations type Signed-off-by: peng.xin <peng.xin@ly.com> - add statefulet group check - modify the pod create processing logic Signed-off-by: peng.xin <peng.xin@ly.com> refactor: pps watch of whitelist workload Signed-off-by: peng.xin <peng.xin@ly.com> fix: add statefulsetlike's pod controller Signed-off-by: peng.xin <peng.xin@ly.com>
ppbits
pushed a commit
to ppbits/kruise
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: liheng.zms liheng.zms@alibaba-inc.com
Ⅰ. Describe what this PR does