Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support timezone for AdvancedCronJob #1070

Merged

Conversation

FillZpp
Copy link
Member

@FillZpp FillZpp commented Sep 6, 2022

Ⅰ. Describe what this PR does

Support timezone for AdvancedCronJob.
Refer to kubernetes/kubernetes#108032

Ⅱ. Does this pull request fix one issue?

fixes #974

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

Merging #1070 (b3719fe) into master (5839c5b) will decrease coverage by 0.24%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #1070      +/-   ##
==========================================
- Coverage   50.46%   50.22%   -0.25%     
==========================================
  Files         125      126       +1     
  Lines       17688    17839     +151     
==========================================
+ Hits         8927     8959      +32     
- Misses       7785     7891     +106     
- Partials      976      989      +13     
Flag Coverage Δ
unittests 50.22% <50.00%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...alidating/advancedcronjob_create_update_handler.go 23.57% <40.74%> (ø)
...ontroller/advancedcronjob/advancedcronjob_utils.go 75.00% <63.63%> (-25.00%) ⬇️
...cronjob/advancedcronjob_broadcastjob_controller.go 21.30% <100.00%> (ø)
.../advancedcronjob/advancedcronjob_job_controller.go 20.96% <100.00%> (ø)
pkg/controller/cloneset/cloneset_controller.go 52.94% <0.00%> (-2.25%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
@FillZpp FillZpp force-pushed the support-timezone-for-advanced-cronjob branch from cf84b04 to b3719fe Compare September 6, 2022 08:27
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@FillZpp
Copy link
Member Author

FillZpp commented Sep 7, 2022

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 4edba53 into openkruise:master Sep 7, 2022
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Sep 14, 2022
Signed-off-by: FillZpp <FillZpp.pub@gmail.com>

Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
baxiaoshi pushed a commit to baxiaoshi/kruise that referenced this pull request Nov 21, 2022
Signed-off-by: peng.xin <peng.xin@ly.com>

optimize workloadspread when suitable subset maxReplicas is niil (openkruise#1066)

Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>

Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>

Optimize performance of LabelSelector conversion (openkruise#1068)

Signed-off-by: FillZpp <FillZpp.pub@gmail.com>

Signed-off-by: FillZpp <FillZpp.pub@gmail.com>

Support timezone for AdvancedCronJob (openkruise#1070)

Signed-off-by: FillZpp <FillZpp.pub@gmail.com>

Signed-off-by: FillZpp <FillZpp.pub@gmail.com>

ignore if pod condition has been updated (openkruise#1074)

Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>

Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>

pod probe marker apis (openkruise#1073)

* pod probe marker apis

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

* fix statefulset truncateHistory panic

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

pod probe marker controller (openkruise#1075)

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

consider whether patch field is matched when assign existing pods to subset (openkruise#1083)

Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>

Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>

pod probe marker webhook (openkruise#1078)

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

sidecarset support pods ns(kube-system, kube-public) (openkruise#1084)

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

pod probe marker proposal (openkruise#1053)

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

node pod probe daemon (openkruise#1077)

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

sidecarset support patch pod metadata proposal (openkruise#993)

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

Support predownload image in ads (openkruise#1057)

Signed-off-by: Abner <abner199709@gmail.com>

* support predownload image for ads

Add PreDownloadImageForDaemonSetUpdate featureGate (openkruise#1093)

Signed-off-by: FillZpp <FillZpp.pub@gmail.com>

Signed-off-by: FillZpp <FillZpp.pub@gmail.com>

Add changelog for v1.3.0 (openkruise#1092)

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

fix sidecarset inject annotations abnormal (openkruise#1101)

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

fix InPlaceUpdateEnvFromMetadata bug (openkruise#1108)

Co-authored-by: 郭已钦 <xiangyang2@xiaohongshu.com>

support uniteddeployment persistentVolumeClaimRetentionPolicy inherit from  advancestatefulset template (openkruise#1110)

Signed-off-by: cheyuexian <cheyuexian@bilibili.com>

Signed-off-by: cheyuexian <cheyuexian@bilibili.com>
Co-authored-by: cheyuexian <cheyuexian@bilibili.com>

Add PreNormal Lifecycle Hook for CloneSet (openkruise#1071)

* add pre-normal(pre-available) hook

Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>

* add pre-normal(pre-available) hook

Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>

Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>

partition support float percent (openkruise#1124)

Signed-off-by: shiyan2016 <shiyan20160606@gmail.com>

Signed-off-by: shiyan2016 <shiyan20160606@gmail.com>

improve error hanlding of inplace update env from metadata (openkruise#1125)

Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>

Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>

pub support to configure Evict,Delete,Update Operation (openkruise#1126)

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

feat: add watch whitelist

feat: add watch whitelist

add watch whitelist check

add dynamic watch option

feat: add persistent annotations

format

feat: add pps support custom workload

Signed-off-by: peng.xin <peng.xin@ly.com>

fix: nodeSelector and nodeAffinity have not been modified

Signed-off-by: peng.xin <peng.xin@ly.com>

fix: error string

Signed-off-by: peng.xin <peng.xin@ly.com>

fix: error string

Signed-off-by: peng.xin <peng.xin@ly.com>

fix: goimports

Signed-off-by: peng.xin <peng.xin@ly.com>

refactor: refactoring ersistentPodAnnotations type

Signed-off-by: peng.xin <peng.xin@ly.com>

- add statefulet group check
- modify the pod create processing logic

Signed-off-by: peng.xin <peng.xin@ly.com>

refactor: pps watch of whitelist workload

Signed-off-by: peng.xin <peng.xin@ly.com>

fix: add statefulsetlike's pod controller

Signed-off-by: peng.xin <peng.xin@ly.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] TimeZone support for AdvancedCronJob from upstream
4 participants