Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: DaemonSet support pre-download image after a few new Pods have been updated ready. #1340

Closed
wants to merge 1 commit into from

Conversation

Hanmengnan
Copy link

Ⅰ. Describe what this PR does

Add apps.kruise.io/image-predownload-min-updated-ready-pods annotations to make to make sure the new image starting pre-download after a few new Pods have been updated ready.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@sonatype-lift
Copy link

sonatype-lift bot commented Jul 23, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval by writing /assign @fillzpp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot added the size/S size/S 10-29 label Jul 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2023

Codecov Report

Merging #1340 (9c95545) into master (4e35a1d) will not change coverage.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #1340   +/-   ##
=======================================
  Coverage   48.60%   48.60%           
=======================================
  Files         152      152           
  Lines       21333    21333           
=======================================
  Hits        10369    10369           
  Misses       9828     9828           
  Partials     1136     1136           
Flag Coverage Δ
unittests 48.60% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/daemonset/daemonset_controller.go 41.60% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…ReadyPodsCount

Signed-off-by: Hanmengnan <1448189829@qq.com>
Copy link

stale bot commented Nov 20, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 20, 2023
@stale stale bot closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S size/S 10-29 wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants