Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement StatefulSetStartOrdinal #1643

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

ABNER-1
Copy link
Member

@ABNER-1 ABNER-1 commented Jun 6, 2024

Ⅰ. Describe what this PR does

implement StatefulSetStartOrdinal

Ⅱ. Does this pull request fix one issue?

fixes #1642

Ⅲ. Describe how to verify it

implement StatefulSetStartOrdinal

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot requested review from Fei-Guo and zmberg June 6, 2024 11:37
@kruise-bot kruise-bot added the size/XL size/XL: 500-999 label Jun 6, 2024
@ABNER-1 ABNER-1 force-pushed the sts-vct-reconcile branch from 113f941 to 87349c2 Compare June 7, 2024 02:48
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 85.41667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 49.21%. Comparing base (0d0031a) to head (b7e0ff7).
Report is 45 commits behind head on master.

Files Patch % Lines
pkg/controller/statefulset/stateful_pod_control.go 37.50% 3 Missing and 2 partials ⚠️
pkg/controller/statefulset/stateful_set_control.go 90.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1643      +/-   ##
==========================================
+ Coverage   47.91%   49.21%   +1.30%     
==========================================
  Files         162      183      +21     
  Lines       23491    18951    -4540     
==========================================
- Hits        11256     9327    -1929     
+ Misses      11014     8404    -2610     
+ Partials     1221     1220       -1     
Flag Coverage Δ
unittests 49.21% <85.41%> (+1.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ABNER-1 ABNER-1 force-pushed the sts-vct-reconcile branch from 87349c2 to e4d49f1 Compare June 7, 2024 06:47
@kruise-bot kruise-bot added size/XXL and removed size/XL size/XL: 500-999 labels Jun 7, 2024
@ABNER-1 ABNER-1 force-pushed the sts-vct-reconcile branch 5 times, most recently from 2387ca6 to 37a905b Compare June 13, 2024 02:02
@ABNER-1 ABNER-1 force-pushed the sts-vct-reconcile branch 5 times, most recently from 5218318 to f8bffff Compare June 13, 2024 13:10
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment in L370 also need modification
// slice that will contain all Pods such that 0 <= getOrdinal(pod) < replicaCount and not in reserveOrdinals

apis/apps/v1beta1/statefulset_types.go Outdated Show resolved Hide resolved
pkg/controller/statefulset/stateful_set_control.go Outdated Show resolved Hide resolved
pkg/controller/statefulset/stateful_set_control.go Outdated Show resolved Hide resolved
pkg/controller/statefulset/stateful_set_utils.go Outdated Show resolved Hide resolved
@ABNER-1 ABNER-1 force-pushed the sts-vct-reconcile branch 3 times, most recently from 79b1a43 to 19d6673 Compare June 17, 2024 07:49
Signed-off-by: Abner-1 <yuanyuxing.yyx@alibaba-inc.com>
@ABNER-1 ABNER-1 force-pushed the sts-vct-reconcile branch from 19d6673 to b7e0ff7 Compare June 17, 2024 08:09
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zmberg
Copy link
Member

zmberg commented Jun 17, 2024

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit bbb2d26 into openkruise:master Jun 17, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] StatefulSet StartOrdinal implement
4 participants