Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt sts updateStatefulSet #1648

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

ABNER-1
Copy link
Contributor

@ABNER-1 ABNER-1 commented Jun 17, 2024

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #1647

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot added the size/XL size/XL: 500-999 label Jun 17, 2024
pkg/controller/statefulset/stateful_set_control.go Outdated Show resolved Hide resolved
pkg/controller/statefulset/stateful_set_control.go Outdated Show resolved Hide resolved
pkg/controller/statefulset/stateful_set_control.go Outdated Show resolved Hide resolved
pkg/controller/statefulset/stateful_set_control.go Outdated Show resolved Hide resolved
pkg/controller/statefulset/stateful_set_control.go Outdated Show resolved Hide resolved
pkg/controller/statefulset/stateful_set_control.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 65.21739% with 88 lines in your changes missing coverage. Please review.

Project coverage is 49.43%. Comparing base (0d0031a) to head (642ab57).
Report is 47 commits behind head on master.

Files Patch % Lines
pkg/controller/statefulset/stateful_set_control.go 64.08% 68 Missing and 20 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1648      +/-   ##
==========================================
+ Coverage   47.91%   49.43%   +1.51%     
==========================================
  Files         162      183      +21     
  Lines       23491    19015    -4476     
==========================================
- Hits        11256     9400    -1856     
+ Misses      11014     8391    -2623     
- Partials     1221     1224       +3     
Flag Coverage Δ
unittests 49.43% <65.21%> (+1.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Abner-1 <yuanyuxing.yyx@alibaba-inc.com>
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zmberg
Copy link
Member

zmberg commented Jun 18, 2024

/lgtm

@zmberg
Copy link
Member

zmberg commented Jun 18, 2024

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 0f6aada into openkruise:master Jun 18, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Optimize Update Logic for Advanced Stateful Sets
4 participants