Filters need testing around item counts

[rhb123]

On Architectural Histories journal there are lots of correctly tagged reviews but the filter now appears to only recognise one when selected. This is a recent issue as this worked fine previously, if it might be possible to get a fix please? Thank you!

Spotted in JW version 1.7.0 at https://journal.eahn.org/articles/?order_by=-date_published&page=1&paginate_by=25&date_published__date__gte=&date_published__date__lte=&section__pk=300

[mauromsl]

closed by #4453

[mauromsl]

I have to reopen this issue, it is still bugged:

https://journal.eahn.org/articles/?order_by=-date_published&page=1&paginate_by=25&date_published__date__gte=&date_published__date__lte=&section__pk=300

For the record: there are 73 articles returned and rendered

[joemull]

I put in another fix for this bug that I believe has taken care of the reported bug. The form now does the count of items for each facet choice differently. I tested the effects of this new count on PublishedArticlesListView.

The work is in commit f80abbf, which Mauro merged right before tagging v1.7.0 because it was needed urgently for the release cycle.

However I'd like to do a bit more work on this issue to make sure the bug is gone in other views:

• add view tests to the other places that inherit GenericFacetedListView to make sure the foreign_key facets they create are treated the same by the CBVFacetForm as the PublishedArticlesListView
• add view tests to check the counts created by CBVFacetForm for charfield_with_choices facets, and fix if needed

See also

• Supporter search page does not show accurate counts in filters consortial_billing#80
• DOI Manager adjustments #2951