Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the item counts on the filters on the article search page #4453

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Fix the item counts on the filters on the article search page #4453

merged 2 commits into from
Oct 10, 2024

Conversation

joemull
Copy link
Member

@joemull joemull commented Oct 9, 2024

Fixes #4449.

Note that installations running the isolinear plugin will also need openlibhums/isolinear#4

@joemull joemull changed the title B 4449 article search hotfix Fix the item counts on the filters on the article search page Oct 9, 2024
@joemull joemull requested a review from ajrbyers October 9, 2024 15:54
@joemull joemull changed the base branch from master to r-v1.7.x October 9, 2024 15:54
@joemull joemull added this to the v1.7.0 milestone Oct 9, 2024
ajrbyers
ajrbyers approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@ajrbyers ajrbyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm.

@ajrbyers ajrbyers requested a review from mauromsl October 10, 2024 13:30
@mauromsl mauromsl merged commit 0f0b6cd into r-v1.7.x Oct 10, 2024
@mauromsl mauromsl deleted the b-4449-article-search-hotfix branch October 10, 2024 14:03
@mauromsl mauromsl mentioned this pull request Oct 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajrbyers ajrbyers ajrbyers approved these changes

@mauromsl mauromsl mauromsl approved these changes

Assignees

@ajrbyers ajrbyers

@mauromsl mauromsl

Labels
priority-urgent
Projects
None yet
Milestone
v1.7.x
Development

Successfully merging this pull request may close these issues.

Filters need testing around item counts
3 participants
@joemull @ajrbyers @mauromsl