-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3-3505: Datepicker improvements #1099
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +298 kB (+5.79%) 🔍 Total Size: 5.46 MB
ℹ️ View Unchanged
|
ibacher
force-pushed
the
feat/datepicker-improvments
branch
2 times, most recently
from
July 30, 2024 18:53
c28d8fd
to
49157c4
Compare
ibacher
force-pushed
the
feat/datepicker-improvments
branch
from
July 30, 2024 18:54
f501fc0
to
6e31c4e
Compare
4 tasks
NethmiRodrigo
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ibacher! LGTM!
3 tasks
4 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat
,fix
, orchore
, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
This PR addresses the following issues:
onClick
handler that shows the calendar.en
locales, we force rendering initial zeroes.null
now works as expected.onChange()
now works with normal Javascript "Date" objects (this is a breaking change). If you need the underlying@internationalized/date
, you can supply aonChangeRaw()
handler. Note that only one ofonChange()
andonChangeRaw()
are supported at a time, withonChangeRaw()
overridingonChange()
.en
asen-GB
.Screenshots
Related Issue
https://issues.openmrs.org/browse/O3-3505
Other