Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) O3-3701 update openMrsDatepicker props #357

Closed
wants to merge 1 commit into from

Conversation

kajambiya
Copy link
Collaborator

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Updates the onChange handler to conform to the changes introduced by this PR

Screenshots

Related Issue

Other

@NethmiRodrigo
Copy link
Contributor

There are some other functions that need to be updated as well, I'll do a push

@NethmiRodrigo
Copy link
Contributor

Couldn't push to this so I made a separate PR - #358

@gracepotma
Copy link
Contributor

@kajambiya we are so sorry for your experience here with a sudden closure - it turns out the underlying cause was just that Nethmi was under the impression from some discussions on slack that she was supposed to help ASAP, so when she couldn't update the PR directly, she made the separate PR in order to move quickly. Very good intentions - but we discussed this and totally agree that in the future we should let people know so there are no surprise PR closures. Again I'm sorry for this experience Jovan - we plan to keep doing better together 🙏 💐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants