(fix) O3-3691: The workspace family store shouldn't reset if workspace of same family is launched #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -79 kB (-1.43%) Total Size: 5.46 MB
ℹ️ View Unchanged
|
vasharma05
changed the title
ibacher
requested changes
Jul 31, 2024
There was a problem hiding this comment.
Thanks @vasharma05! A couple of minor things. Overall question though: doesn't this remove the check for existing open workspaces while fixing a bug when opening a new workspace?
packages/framework/esm-styleguide/src/workspaces/container/workspace-renderer.test.tsx
Outdated
Show resolved
Hide resolved
|
I would rather the family workspace store stayed out of the API entirely. There's no reason that workspace client code should know about family workspace stores, and if you expose that in the API, you have to explain the whole thing. We can avoid that by creating a new function, called something like |
…same sidebar family as of the workspace to be closed
…the dependency array for the props
Co-authored-by: Brandon Istenes <bistenes@gmail.com>
|
Hi @brandones @ibacher, requesting your review here. |
Co-authored-by: Ian <52504170+ibacher@users.noreply.github.com>
brandones
reviewed
Aug 1, 2024
brandones
reviewed
Aug 1, 2024
packages/framework/esm-styleguide/src/workspaces/workspaces.test.ts
Outdated
Show resolved
Hide resolved
brandones
reviewed
Aug 1, 2024
packages/framework/esm-styleguide/src/workspaces/workspaces.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Brandon Istenes <bistenes@gmail.com>
brandones
approved these changes
Aug 1, 2024
ibacher
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat,fix, orchore, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
The issue comes from this line which does check that the workspaces remaining do have the same sidebar family name and doesn’t check the fact that the new workspace to be opened is of the same family, hence it shouldn’t clear the workspace.
The reason behind this is that when we launch 2nd workspace, it will first close the 1st workspace and as per the condition linked above, it will reset the store, which is not ideal. We need a condition that if the new workspace is opened of the same sidebar family and the previous workspace is closing, the store shouldn't clear itself.
Addition: Added tests for workspace renderer to test if the valid props are being passed into the workspace or not.
Screenshots
None
Related Issue
https://issues.openmrs.org/browse/O3-3691
Other
Fun fact:
This issue would've been caught earlier by my unit tests if I hadn't added this line in a test case in my previous PR #1094