Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) O3-3691: The workspace family store shouldn't reset if workspace of same family is launched #1103

Merged
merged 13 commits into from
Aug 1, 2024
Merged

(fix) O3-3691: The workspace family store shouldn't reset if workspace of same family is launched #1103

merged 13 commits into from
Aug 1, 2024

Commits on Aug 1, 2024

  1. Adding a new check to know that the workspace to be opened is of the … 

    …same sidebar family as of the workspace to be closed
    @vasharma05
    vasharma05 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    47d2dd2 View commit details
    Browse the repository at this point in the history

  2. Added tests for workspace renderer and added workspaceFamilyState in … 

    …the dependency array for the props
    @vasharma05
    vasharma05 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    245575f View commit details
    Browse the repository at this point in the history

  3. Updated documentation

    @vasharma05
    vasharma05 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    f18c193 View commit details
    Browse the repository at this point in the history

  4. Add check for not clearing store if workspace is opened in the backgr… 

    …ound
    @vasharma05
    vasharma05 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    c0185a6 View commit details
    Browse the repository at this point in the history

  5. Updated documentation

    @vasharma05
    vasharma05 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    36fba03 View commit details
    Browse the repository at this point in the history

  6. Review updates

    @vasharma05
    vasharma05 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    59d69b2 View commit details
    Browse the repository at this point in the history

  7. Updated documentation

    @vasharma05
    vasharma05 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    eeeda13 View commit details
    Browse the repository at this point in the history

  8. Separate workspace family store handling from closeWorkspace API 

    Co-authored-by: Brandon Istenes <bistenes@gmail.com>
    @vasharma05 @brandones
    vasharma05 and brandones committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    adb776f View commit details
    Browse the repository at this point in the history

  9. Update documentation

    @vasharma05
    vasharma05 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    af4105d View commit details
    Browse the repository at this point in the history

  10. Update packages/framework/esm-styleguide/src/workspaces/workspaces.ts 

    Co-authored-by: Ian <52504170+ibacher@users.noreply.github.com>
    @brandones @ibacher
    brandones and ibacher authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    f76082b View commit details
    Browse the repository at this point in the history

  11. Update the comment for testing the default options 

    Co-authored-by: Brandon Istenes <bistenes@gmail.com>
    @vasharma05 @brandones
    vasharma05 and brandones authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    3e17514 View commit details
    Browse the repository at this point in the history

  12. Review changes

    @vasharma05
    vasharma05 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    4c5a69f View commit details
    Browse the repository at this point in the history

  13. Update documentation

    @vasharma05
    vasharma05 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    180afe2 View commit details
    Browse the repository at this point in the history