(fix) App not hot updating with slot config changes #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandones
changed the title
brandones
force-pushed
the
ext-slot-conf-update
branch
from
78fef85
to
d5ae830
Compare
File size impactMerging ext-slot-conf-update into master impact files as follow: @openmrs/esm-devtools-app (+1.81%)
@openmrs/esm-implementer-tools-app (+0.33%)
@openmrs/esm-login-app (+0.39%)
@openmrs/esm-offline-tools-app (+0.28%)
@openmrs/esm-primary-navigation-app (+0.36%)
@openmrs/esm-app-shell (+0.17%)
|
File size impactMerging ext-slot-conf-update into master impact files as follow: @openmrs/esm-devtools-app (+1.81%)
@openmrs/esm-implementer-tools-app (+0.33%)
@openmrs/esm-login-app (+0.39%)
@openmrs/esm-offline-tools-app (+0.28%)
@openmrs/esm-primary-navigation-app (+0.36%)
@openmrs/esm-app-shell (+0.17%)
|
ZacButko
reviewed
Mar 14, 2022
| ); | ||
| const slotStore = getExtensionSlotsConfigStore(); | ||
| const oldState = slotStore.getState(); | ||
| const newState = { slots: { ...oldState.slots, ...newSlotStoreEntries } }; |
There was a problem hiding this comment.
This will not remove oldState slots if they are meant to be removed. Is it desired to remove old unused slots from state?
There was a problem hiding this comment.
I asked @brandones a similar question once and he indicated the idea is to keep the slots around so that the implementer tools can track them even if the slot itself is no longer rendered.
There was a problem hiding this comment.
@ibacher is correct. There will not be so many that it will be a memory problem.
|
|
||
| function useStore<T, U>(store: Store<T>): T; | ||
| function useStore<T, U>(store: Store<T>, select: (state: T) => U): U; | ||
| function useStore<T, U>( |
There was a problem hiding this comment.
What are all of these declarations for? You're just declaring a function then immediately overwriting it?
There was a problem hiding this comment.
ZacButko
approved these changes
Mar 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
Fixes a bug where the app does not hot update in response to extension slot config changes.
Includes a breaking change to
useStoreanduseStoreState, but this will not affect any existing users.Screenshots