(fix) App not hot updating with slot config changes

.husky/pre-commit

@@ -4,5 +4,5 @@
 set -e  # die on error
 
 yarn run extract-translations
-npx pretty-quick --staged
-npx lerna run document --since master
+yarn pretty-quick --staged
+yarn lerna run document --since master

.husky/pre-push

@@ -3,6 +3,6 @@
 
 set -e  # die on error
 
-npx lerna run lint --since master
-npx lerna run test --since master
-npx lerna run typescript --since master
+yarn lerna run lint --since master
+yarn lerna run test --since master
+yarn lerna run typescript --since master

packages/apps/esm-implementer-tools-app/src/configuration/configuration.component.tsx

@@ -7,10 +7,11 @@ import {
   Config,
   ConfigInternalStore,
   configInternalStore,
+  getExtensionInternalStore,
   implementerToolsConfigStore,
   temporaryConfigStore,
-  useExtensionInternalStore,
   useStore,
+  useStoreWithActions,
 } from "@openmrs/esm-framework";
 import {
   Button,
@@ -89,13 +90,13 @@ export const Configuration: React.FC<ConfigurationProps> = () => {
     toggleIsJsonModeEnabled,
     isConfigToolbarOpen,
     toggleIsToolbarOpen,
-  } = useStore(implementerToolsStore, actions);
-  const { devDefaultsAreOn, toggleDevDefaults } = useStore(
+  } = useStoreWithActions(implementerToolsStore, actions);
+  const { devDefaultsAreOn, toggleDevDefaults } = useStoreWithActions(
     configInternalStore,
     configActions
   );
   const { config } = useStore(implementerToolsConfigStore);
-  const extensionStore = useExtensionInternalStore();
+  const extensionStore = useStore(getExtensionInternalStore());
   const tempConfigStore = useStore(temporaryConfigStore);
   const [filterText, setFilterText] = useState("");
   const tempConfig = tempConfigStore.config;

packages/apps/esm-implementer-tools-app/src/ui-editor/ui-editor.tsx

@@ -1,14 +1,18 @@
 import React from "react";
 import styles from "./styles.css";
 import Close16 from "@carbon/icons-react/es/close/16";
-import { useExtensionInternalStore, useStore } from "@openmrs/esm-framework";
+import {
+  getExtensionInternalStore,
+  useStore,
+  useStoreWithActions,
+} from "@openmrs/esm-framework";
 import { Button } from "carbon-components-react";
 import { Portal } from "./portal";
 import { ExtensionOverlay } from "./extension-overlay.component";
 import { ImplementerToolsStore, implementerToolsStore } from "../store";
 
 export default function UiEditor() {
-  const { slots, extensions } = useExtensionInternalStore();
+  const { slots, extensions } = useStore(getExtensionInternalStore());
   const { isOpen: implementerToolsIsOpen } = useStore(implementerToolsStore);
 
   return (
@@ -66,7 +70,10 @@ const actions = {
 };
 
 export function ExitButton() {
-  const { toggleIsUIEditorEnabled } = useStore(implementerToolsStore, actions);
+  const { toggleIsUIEditorEnabled } = useStoreWithActions(
+    implementerToolsStore,
+    actions
+  );
   return (
     <Button
       className={styles.exitButton}

packages/framework/esm-config/src/module-config/module-config.test.ts

@@ -17,7 +17,7 @@ import {
   temporaryConfigStore,
 } from "./state";
 import { Type } from "../types";
-import { getExtensionSlotConfigStore } from "..";
+import { getExtensionSlotsConfigStore } from "..";
 
 const mockConfigInternalStore =
   configInternalStore as MockedStore<ConfigInternalStore>;
@@ -854,7 +854,8 @@ describe("extension slot config", () => {
         },
       },
     });
-    const { config } = getExtensionSlotConfigStore("fooSlot").getState();
+    const { config } =
+      getExtensionSlotsConfigStore().getState().slots["fooSlot"];
     expect(config).toStrictEqual({
       add: ["bar", "baz"],
       remove: ["zap"],
@@ -892,7 +893,8 @@ describe("extension slot config", () => {
       },
     });
     await Config.getConfig("foo-module");
-    const { config } = getExtensionSlotConfigStore("fooSlot").getState();
+    const { config } =
+      getExtensionSlotsConfigStore().getState().slots["fooSlot"];
     expect(config).toStrictEqual({ remove: ["bar"] });
   });
 

packages/framework/esm-config/src/module-config/module-config.ts

@@ -1,4 +1,4 @@
-import { clone, reduce, mergeDeepRight } from "ramda";
+import { clone, reduce, mergeDeepRight, equals } from "ramda";
 import {
   Config,
   ConfigObject,
@@ -23,9 +23,9 @@ import {
   configExtensionStore,
   getConfigStore,
   getExtensionConfigStore,
-  getExtensionSlotConfigStore,
   implementerToolsConfigStore,
   temporaryConfigStore,
+  getExtensionSlotsConfigStore,
 } from "./state";
 import type {} from "@openmrs/esm-globals";
 import { TemporaryConfigStore } from "..";
@@ -125,9 +125,17 @@ function computeExtensionSlotConfigs(
   tempState: TemporaryConfigStore
 ) {
   const slotConfigs = getExtensionSlotConfigs(state, tempState);
-  for (let [slotName, config] of Object.entries(slotConfigs)) {
-    const slotStore = getExtensionSlotConfigStore(slotName);
-    slotStore.setState({ loaded: true, config });
+  const newSlotStoreEntries = Object.fromEntries(
+    Object.entries(slotConfigs).map(([slotName, config]) => [
+      slotName,
+      { loaded: true, config },
+    ])
+  );
+  const slotStore = getExtensionSlotsConfigStore();
+  const oldState = slotStore.getState();
+  const newState = { slots: { ...oldState.slots, ...newSlotStoreEntries } };
+  if (!equals(oldState, newState)) {
+    slotStore.setState(newState);
   }
 }
 

packages/framework/esm-config/src/module-config/state.ts

@@ -141,29 +141,42 @@ export function getConfigStore(moduleName: string) {
 }
 
 /**
- * Configuration for a specific extension slot
+ * Configuration for all the specific extension slots
  * @internal
  */
-export interface ExtensionSlotConfigStore {
-  config: ExtensionSlotConfigObject;
-  loaded: boolean;
+export interface ExtensionSlotsConfigStore {
+  slots: {
+    [slotName: string]: {
+      config: ExtensionSlotConfigObject;
+      loaded: boolean;
+    };
+  };
 }
 
-function initializeExtensionSlotConfigStore() {
-  return {
-    config: {},
-    loaded: false,
-  };
+/** @internal */
+export function getExtensionSlotsConfigStore() {
+  return getGlobalStore<ExtensionSlotsConfigStore>(`config-extension-slots`, {
+    slots: {},
+  });
 }
 
 /** @internal */
-export function getExtensionSlotConfigStore(slotName: string) {
-  return getGlobalStore<ExtensionSlotConfigStore>(
-    `config-extension-slots-${slotName}`,
-    initializeExtensionSlotConfigStore()
+export function getExtensionSlotConfig(slotName: string) {
+  return getExtensionSlotConfigFromStore(
+    getExtensionSlotsConfigStore().getState(),
+    slotName
   );
 }
 
+/** @internal */
+export function getExtensionSlotConfigFromStore(
+  state: ExtensionSlotsConfigStore,
+  slotName: string
+) {
+  const slotConfig = state.slots[slotName];
+  return slotConfig ?? { loaded: false, config: {} };
+}
+
 /**
  * A store for each mounted extension's config
  * @internal

packages/framework/esm-extensions/__mocks__/openmrs-esm-config.mock.tsx

@@ -1 +1 @@
-export const getExtensionSlotConfig = jest.fn().mockResolvedValue({});
+export const getExtensionSlotConfigs = jest.fn().mockResolvedValue({});

packages/framework/esm-extensions/src/extensions.ts

@@ -9,8 +9,12 @@
 
 import {
   ExtensionSlotConfigObject,
-  getExtensionSlotConfigStore,
+  ExtensionSlotsConfigStore,
+  getExtensionSlotConfig,
+  getExtensionSlotConfigFromStore,
+  getExtensionSlotsConfigStore,
 } from "@openmrs/esm-config";
+import isEqual from "lodash-es/isEqual";
 import {
   getExtensionInternalStore,
   ExtensionSlotState,
@@ -30,16 +34,40 @@ const extensionInternalStore = getExtensionInternalStore();
 const extensionStore = getExtensionStore();
 
 // Keep the output store updated
-extensionInternalStore.subscribe((internalStore) => {
+function updateExtensionOutputStore(
+  internalState: ExtensionInternalStore,
+  extensionSlotConfigs: ExtensionSlotsConfigStore
+) {
   const slots: Record<string, ExtensionSlotState> = {};
-  for (let [slotName, slot] of Object.entries(internalStore.slots)) {
+  for (let [slotName, slot] of Object.entries(internalState.slots)) {
+    // Only include registered slots
     if (slot.moduleName) {
-      // Only include registered slots
-      const assignedExtensions = getAssignedExtensions(slotName);
+      const { config } = getExtensionSlotConfigFromStore(
+        extensionSlotConfigs,
+        slot.name
+      );
+      const assignedExtensions = getAssignedExtensionsFromData(
+        slotName,
+        internalState,
+        config
+      );
       slots[slotName] = { moduleName: slot.moduleName, assignedExtensions };
     }
   }
-  extensionStore.setState({ slots: slots });
+  if (!isEqual(extensionStore.getState().slots, slots)) {
+    extensionStore.setState({ slots });
+  }
+}
+
+extensionInternalStore.subscribe((internalStore) => {
+  updateExtensionOutputStore(
+    internalStore,
+    getExtensionSlotsConfigStore().getState()
+  );
+});
+
+getExtensionSlotsConfigStore().subscribe((slotConfigs) => {
+  updateExtensionOutputStore(extensionInternalStore.getState(), slotConfigs);
 });
 
 function createNewExtensionSlotInfo(
@@ -246,11 +274,11 @@ export function getConnectedExtensions(
   );
 }
 
-export function getAssignedExtensions(
-  slotName: string
+function getAssignedExtensionsFromData(
+  slotName: string,
+  internalState: ExtensionInternalStore,
+  config: ExtensionSlotConfigObject
 ): Array<AssignedExtension> {
-  const internalState = extensionInternalStore.getState();
-  const config = getExtensionSlotConfigStore(slotName).getState().config;
   const attachedIds = internalState.slots[slotName].attachedIds;
   const assignedIds = calculateAssignedIds(config, attachedIds);
   const extensions: Array<AssignedExtension> = [];
@@ -269,6 +297,14 @@ export function getAssignedExtensions(
   return extensions;
 }
 
+export function getAssignedExtensions(
+  slotName: string
+): Array<AssignedExtension> {
+  const internalState = extensionInternalStore.getState();
+  const { config } = getExtensionSlotConfig(slotName);
+  return getAssignedExtensionsFromData(slotName, internalState, config);
+}
+
 function calculateAssignedIds(
   config: ExtensionSlotConfigObject,
   attachedIds: Array<string>