(fix) Service Worker Housekeeping: Remove Unused SW Events | Fix SW Startup Cycle During Initial Load #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e (as it became obsolete and is no longer used in any module).
…ean up the offline setup and make it more robust (remove potential race-ish conditions).
FlorianRappl
approved these changes
Mar 23, 2022
|
Hi @manuelroemer , do you think this will fix https://issues.openmrs.org/browse/O3-1067 , or is it unrelated? |
|
@brandones I haven't explicitly tested this, but it should be unrelatated to the issue. This fix here is mainly introduced to fix an issue where some data (e.g. static patient-registration files) wasn't properly cached when the page was initially loaded, requiring users to maunally refresh the page once. Though if it does happen to fix the linked issue - even better. ;) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
Housekeeping for the service worker. Removes a now unused event (
networkRequestFailed- was only introduced foresm-form-entryand is now not required anymore). Also improves the startup and SW registration (which should issues with initial caching of resources).