Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Service Worker Housekeeping: Remove Unused SW Events | Fix SW Startup Cycle During Initial Load #369

Merged
merged 3 commits into from
Mar 23, 2022
Merged

(fix) Service Worker Housekeeping: Remove Unused SW Events | Fix SW Startup Cycle During Initial Load #369

merged 3 commits into from
Mar 23, 2022

Commits on Mar 23, 2022

  1. Removed the service worker's networkRequestFailed event infrastructur… 

    …e (as it became obsolete and is no longer used in any module).
    @manuelroemer
    manuelroemer committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    06feda0 View commit details
    Browse the repository at this point in the history

  2. Remove unused variable.

    @manuelroemer
    manuelroemer committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    322132c View commit details
    Browse the repository at this point in the history

  3. Ensure that the SW is responsible for new page registrations. Also cl… 

    …ean up the offline setup and make it more robust (remove potential race-ish conditions).
    @manuelroemer
    manuelroemer committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    287a0cc View commit details
    Browse the repository at this point in the history