Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search locations in the location picker not only on the basis of prefixes #371

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Search locations in the location picker not only on the basis of prefixes #371

merged 2 commits into from
Mar 29, 2022

Conversation

vasharma05
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Currently, when we look for the "Pharmacy" location, we might search with "P, Pha, ...", but searching with "macy" won't yield the required results. Hence I added :contains to the name parameter.

Screenshots

image

Related Issue

https://issues.openmrs.org/browse/O3-1193

Other

@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2022


Error: Error while trying to collect info after merging O3-1193 into master.

Error: Command failed: git fetch --no-tags --prune origin refs/pull/371/merge
fatal: couldn't find remote ref refs/pull/371/merge

    at ChildProcess.exithandler (node:child_process:397:12)
    at ChildProcess.emit (node:events:394:28)
    at maybeClose (node:internal/child_process:1067:16)
    at Socket. (node:internal/child_process:453:11)
    at Socket.emit (node:events:394:28)
    at Pipe. (node:net:672:12)

Generated by @jsenv/file-size-impact during Report bundle size#2058058214 on e0b2077

Copy link
Contributor

@ZacButko ZacButko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Vineet!

@vasharma05 vasharma05 merged commit 31197d8 into openmrs:master Mar 29, 2022
@ZacButko ZacButko mentioned this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants