Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mock setSessionLocation to pass the tests #377

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Added mock setSessionLocation to pass the tests #377

merged 1 commit into from
Apr 4, 2022

Conversation

vasharma05
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

My previous PR #371 was failing the tests, so I have created a new mock mocking the setSessionLocation when
auto-selects the location and navigates away from the page when only one login location is available

Screenshots

None

Related Issue

https://issues.openmrs.org/projects/O3/issues/O3-1222

Other

None

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022

File size impact

Merging O3-1193-tests-fix into master impact files as follow:

@openmrs/esm-devtools-app (no impact)
Files new size
Unmodified (5) 448 kB (0 B / +0%) 👻
Total (5) 448 kB (0 B / +0%) 👻
@openmrs/esm-implementer-tools-app (no impact)
Files new size
Unmodified (21) 2.36 MB (0 B / +0%) 👻
Total (21) 2.36 MB (0 B / +0%) 👻
@openmrs/esm-login-app (no impact)
Files new size
Unmodified (28) 2.04 MB (0 B / +0%) 👻
Total (28) 2.04 MB (0 B / +0%) 👻
@openmrs/esm-offline-tools-app (no impact)
Files new size
Unmodified (26) 2.79 MB (0 B / +0%) 👻
Total (26) 2.79 MB (0 B / +0%) 👻
@openmrs/esm-primary-navigation-app (no impact)
Files new size
Unmodified (18) 2.2 MB (0 B / +0%) 👻
Total (18) 2.2 MB (0 B / +0%) 👻
@openmrs/esm-app-shell (no impact)
Files new size
Unmodified (4) 2.11 MB (0 B / +0%) 👻
Total (4) 2.11 MB (0 B / +0%) 👻
Generated by @jsenv/file-size-impact during Report bundle size#2076544717 on 7ff93df

@brandones brandones merged commit 19b47a5 into openmrs:master Apr 4, 2022
@ZacButko ZacButko mentioned this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants