Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) build command should not default to clearing directory #628

Merged
merged 1 commit into from
Mar 6, 2023
Merged

(fix) build command should not default to clearing directory #628

merged 1 commit into from
Mar 6, 2023

Conversation

ibacher
Copy link
Member

@ibacher ibacher commented Mar 6, 2023

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Basically, this just defaults fresh to false. I think the default of true is undesirable because we would like to do things that require assemble to be run before build and that means we should make clearing the dist folder an option rather than a necessity.

Screenshots

Related Issue

Other

@ibacher ibacher requested a review from denniskigen March 6, 2023 18:39
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023 •
edited
Loading

Size Change: +35 B (0%)

Total Size: 2.19 MB

ℹ️ View Unchanged
Filename Size Change
packages/apps/esm-devtools-app/dist/733.js 4.23 kB 0 B
packages/apps/esm-devtools-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-devtools-app/dist/889.js 109 kB 0 B
packages/apps/esm-devtools-app/dist/988.js 367 B 0 B
packages/apps/esm-devtools-app/dist/main.js 2.87 kB 0 B
packages/apps/esm-devtools-app/dist/openmrs-esm-devtools-app.js 3.04 kB 0 B
packages/apps/esm-implementer-tools-app/dist/102.js 2.76 kB 0 B
packages/apps/esm-implementer-tools-app/dist/146.js 6.72 kB 0 B
packages/apps/esm-implementer-tools-app/dist/246.js 447 B 0 B
packages/apps/esm-implementer-tools-app/dist/280.js 4.02 kB 0 B
packages/apps/esm-implementer-tools-app/dist/284.js 1.47 kB 0 B
packages/apps/esm-implementer-tools-app/dist/319.js 458 B 0 B
packages/apps/esm-implementer-tools-app/dist/369.js 2.63 kB 0 B
packages/apps/esm-implementer-tools-app/dist/406.js 29.3 kB 0 B
packages/apps/esm-implementer-tools-app/dist/466.js 5.82 kB 0 B
packages/apps/esm-implementer-tools-app/dist/531.js 1.66 kB 0 B
packages/apps/esm-implementer-tools-app/dist/574.js 425 B 0 B
packages/apps/esm-implementer-tools-app/dist/620.js 126 kB 0 B
packages/apps/esm-implementer-tools-app/dist/626.js 5.06 kB 0 B
packages/apps/esm-implementer-tools-app/dist/684.js 61.8 kB 0 B
packages/apps/esm-implementer-tools-app/dist/697.js 11.7 kB 0 B
packages/apps/esm-implementer-tools-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-implementer-tools-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-implementer-tools-app/dist/889.js 109 kB 0 B
packages/apps/esm-implementer-tools-app/dist/895.js 2.29 kB 0 B
packages/apps/esm-implementer-tools-app/dist/main.js 3.94 kB 0 B
packages/apps/esm-implementer-tools-app/dist/openmrs-esm-implementer-tools-app.js 3.26 kB 0 B
packages/apps/esm-login-app/dist/236.js 272 B 0 B
packages/apps/esm-login-app/dist/240.js 364 B 0 B
packages/apps/esm-login-app/dist/272.js 264 B 0 B
packages/apps/esm-login-app/dist/319.js 360 B 0 B
packages/apps/esm-login-app/dist/336.js 234 B 0 B
packages/apps/esm-login-app/dist/390.js 603 B 0 B
packages/apps/esm-login-app/dist/406.js 5.8 kB 0 B
packages/apps/esm-login-app/dist/420.js 1.62 kB 0 B
packages/apps/esm-login-app/dist/495.js 10 kB 0 B
packages/apps/esm-login-app/dist/529.js 24.9 kB 0 B
packages/apps/esm-login-app/dist/539.js 298 B 0 B
packages/apps/esm-login-app/dist/574.js 428 B 0 B
packages/apps/esm-login-app/dist/607.js 10.7 kB 0 B
packages/apps/esm-login-app/dist/611.js 726 B 0 B
packages/apps/esm-login-app/dist/644.js 305 B 0 B
packages/apps/esm-login-app/dist/673.js 284 B 0 B
packages/apps/esm-login-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-login-app/dist/757.js 603 B 0 B
packages/apps/esm-login-app/dist/759.js 16.5 kB 0 B
packages/apps/esm-login-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-login-app/dist/889.js 109 kB 0 B
packages/apps/esm-login-app/dist/925.js 6.66 kB 0 B
packages/apps/esm-login-app/dist/951.js 6.25 kB 0 B
packages/apps/esm-login-app/dist/98.js 5.71 kB 0 B
packages/apps/esm-login-app/dist/main.js 3.3 kB 0 B
packages/apps/esm-login-app/dist/openmrs-esm-login-app.js 3.18 kB 0 B
packages/apps/esm-offline-tools-app/dist/126.js 6.31 kB 0 B
packages/apps/esm-offline-tools-app/dist/259.js 12.3 kB 0 B
packages/apps/esm-offline-tools-app/dist/290.js 439 B 0 B
packages/apps/esm-offline-tools-app/dist/316.js 2.07 kB 0 B
packages/apps/esm-offline-tools-app/dist/373.js 2.83 kB 0 B
packages/apps/esm-offline-tools-app/dist/391.js 305 B 0 B
packages/apps/esm-offline-tools-app/dist/412.js 2.34 kB 0 B
packages/apps/esm-offline-tools-app/dist/456.js 6.75 kB 0 B
packages/apps/esm-offline-tools-app/dist/518.js 11.2 kB 0 B
packages/apps/esm-offline-tools-app/dist/530.js 6.13 kB 0 B
packages/apps/esm-offline-tools-app/dist/534.js 5.47 kB 0 B
packages/apps/esm-offline-tools-app/dist/541.js 384 B 0 B
packages/apps/esm-offline-tools-app/dist/574.js 999 B 0 B
packages/apps/esm-offline-tools-app/dist/58.js 6.53 kB 0 B
packages/apps/esm-offline-tools-app/dist/733.js 290 B 0 B
packages/apps/esm-offline-tools-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-offline-tools-app/dist/740.js 9.62 kB 0 B
packages/apps/esm-offline-tools-app/dist/750.js 17.2 kB 0 B
packages/apps/esm-offline-tools-app/dist/757.js 1.15 kB 0 B
packages/apps/esm-offline-tools-app/dist/759.js 16.5 kB 0 B
packages/apps/esm-offline-tools-app/dist/775.js 51.7 kB 0 B
packages/apps/esm-offline-tools-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-offline-tools-app/dist/802.js 7.21 kB 0 B
packages/apps/esm-offline-tools-app/dist/889.js 109 kB 0 B
packages/apps/esm-offline-tools-app/dist/925.js 6.67 kB 0 B
packages/apps/esm-offline-tools-app/dist/967.js 493 B 0 B
packages/apps/esm-offline-tools-app/dist/996.js 15.6 kB 0 B
packages/apps/esm-offline-tools-app/dist/main.js 58.1 kB 0 B
packages/apps/esm-offline-tools-app/dist/openmrs-esm-offline-tools-app.js 3.26 kB 0 B
packages/apps/esm-primary-navigation-app/dist/146.js 6.72 kB 0 B
packages/apps/esm-primary-navigation-app/dist/216.js 549 B 0 B
packages/apps/esm-primary-navigation-app/dist/34.js 3.04 kB 0 B
packages/apps/esm-primary-navigation-app/dist/345.js 11.6 kB 0 B
packages/apps/esm-primary-navigation-app/dist/414.js 467 B 0 B
packages/apps/esm-primary-navigation-app/dist/473.js 6.08 kB 0 B
packages/apps/esm-primary-navigation-app/dist/574.js 183 B 0 B
packages/apps/esm-primary-navigation-app/dist/656.js 14.8 kB 0 B
packages/apps/esm-primary-navigation-app/dist/710.js 6.28 kB 0 B
packages/apps/esm-primary-navigation-app/dist/723.js 4.53 kB 0 B
packages/apps/esm-primary-navigation-app/dist/735.js 2.64 kB 0 B
packages/apps/esm-primary-navigation-app/dist/757.js 209 B 0 B
packages/apps/esm-primary-navigation-app/dist/787.js 9.38 kB 0 B
packages/apps/esm-primary-navigation-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-primary-navigation-app/dist/889.js 109 kB 0 B
packages/apps/esm-primary-navigation-app/dist/98.js 7.05 kB 0 B
packages/apps/esm-primary-navigation-app/dist/main.js 9.4 kB 0 B
packages/apps/esm-primary-navigation-app/dist/openmrs-esm-primary-navigation-app.js 3.28 kB 0 B
packages/framework/esm-api/dist/openmrs-esm-api.js 9.49 kB 0 B
packages/framework/esm-breadcrumbs/dist/openmrs-esm-breadcrumbs.js 3.24 kB 0 B
packages/framework/esm-config/dist/openmrs-esm-module-config.js 7.87 kB 0 B
packages/framework/esm-error-handling/dist/openmrs-esm-error-handling.js 1.49 kB 0 B
packages/framework/esm-extensions/dist/openmrs-esm-extensions.js 8.45 kB 0 B
packages/framework/esm-framework/dist/openmrs-esm-framework.js 202 kB 0 B
packages/framework/esm-globals/dist/openmrs-esm-globals.js 1.59 kB 0 B
packages/framework/esm-offline/dist/openmrs-esm-offline.js 35 kB 0 B
packages/framework/esm-react-utils/dist/openmrs-esm-react-utils.js 18.2 kB 0 B
packages/framework/esm-state/dist/openmrs-esm-state.js 1.47 kB 0 B
packages/framework/esm-styleguide/dist/openmrs-esm-styleguide.js 19 kB 0 B
packages/framework/esm-utils/dist/openmrs-esm-utils.js 10.8 kB 0 B
packages/shell/esm-app-shell/dist/c6b5b7cb57de5ec56df3.js 922 B 0 B
packages/shell/esm-app-shell/dist/openmrs.57af6cb9c5ff7fc43e47.js 350 kB 0 B
packages/shell/esm-app-shell/dist/service-worker.js 51.1 kB 0 B
packages/tooling/openmrs/dist/cli.js 2.84 kB +35 B (+1%)
packages/tooling/openmrs/dist/commands/assemble.js 2.44 kB 0 B
packages/tooling/openmrs/dist/commands/build.js 1.16 kB 0 B
packages/tooling/openmrs/dist/commands/debug.js 539 B 0 B
packages/tooling/openmrs/dist/commands/develop.js 1.66 kB 0 B
packages/tooling/openmrs/dist/commands/index.js 360 B 0 B
packages/tooling/openmrs/dist/commands/start.js 848 B 0 B
packages/tooling/openmrs/dist/index.js 445 B 0 B
packages/tooling/openmrs/dist/runner.js 799 B 0 B
packages/tooling/openmrs/dist/utils/config.js 639 B 0 B
packages/tooling/openmrs/dist/utils/debugger.js 529 B 0 B
packages/tooling/openmrs/dist/utils/dependencies.js 300 B 0 B
packages/tooling/openmrs/dist/utils/helpers.js 275 B 0 B
packages/tooling/openmrs/dist/utils/importmap.js 2.79 kB 0 B
packages/tooling/openmrs/dist/utils/index.js 370 B 0 B
packages/tooling/openmrs/dist/utils/logger.js 234 B 0 B
packages/tooling/openmrs/dist/utils/npmConfig.js 854 B 0 B
packages/tooling/openmrs/dist/utils/untar.js 648 B 0 B
packages/tooling/openmrs/dist/utils/variables.js 192 B 0 B
packages/tooling/openmrs/dist/utils/webpack.js 276 B 0 B
packages/tooling/webpack-config/dist/index.js 3.01 kB 0 B
packages/tooling/webpack-config/dist/optimize.js 1.79 kB 0 B

compressed-size-action

@ibacher ibacher merged commit 9c351f8 into main Mar 6, 2023
@ibacher ibacher deleted the fix/fresh-false-default branch March 6, 2023 19:13
@ibacher ibacher mentioned this pull request Mar 22, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denniskigen denniskigen denniskigen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibacher @denniskigen