-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) build command should not default to clearing directory #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +35 B (0%) Total Size: 2.19 MB ℹ️ View Unchanged
|
denniskigen
approved these changes
Mar 6, 2023
ibacher
force-pushed
the
fix/fresh-false-default
branch
from
March 6, 2023 18:45
eebcd8e
to
34b4012
Compare
ibacher
force-pushed
the
fix/fresh-false-default
branch
from
March 6, 2023 18:45
34b4012
to
0aa21a3
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
Basically, this just defaults
fresh
tofalse
. I think the default oftrue
is undesirable because we would like to do things that requireassemble
to be run beforebuild
and that means we should make clearing thedist
folder an option rather than a necessity.Screenshots
Related Issue
Other