-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Control clean plugin through CLI #650
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -350 kB (-14%) 👏 Total Size: 2.19 MB
ℹ️ View Unchanged
|
vasharma05
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
Hopefully the last PR related to caching for a bit.
#628 attempted to fix this by defaulting the
--fresh
argument tofalse
. Unfortunately, it turns out that--fresh
wasn't the only thing clearing out the build directory, we were also using theCleanWebpackPlugin
. TheCleanWebpackPlugin
is necessary when actually building the shell as part of the release process for this repo, but isn't useful when running the build using the CLI in conjunction with theassemble
command, so this PR makes it possible to turn off theCleanWebpackPlugin
and re-wires the--fresh
option on thebuild
command to control theCleanWebpackPlugin
.Screenshots
Related Issue
Other