(chore) align and clean up dependencies #165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there also some few typescript issues |
| @@ -51,22 +51,22 @@ export const OHRIMultiSelect: React.FC<OHRIFormFieldProps> = ({ question, onChan | |||
| })); | |||
|
|
|||
| const initiallySelectedQuestionItems = []; | |||
| questionItems.forEach(item => { | |||
| questionItems.forEach((item) => { | |||
There was a problem hiding this comment.
Hey, why haven't you use map instead of forEach?
There was a problem hiding this comment.
@raghavawasthi24 Thanks for pointing this out. This PR was however for aligning the dependencies and some of the changes to files like this one was due to the linter. There's another PR that has been merged with some fixes.
Also feel free to take a look at the codebase and suggest improvements, tickets or even PR's where you see fit.
pirupius
force-pushed
the
chore/align-and-clean-dependencies
branch
from
20ebdf7
to
8c5cf5b
Compare
|
Closed this as it was too stale in favor of #176 with a cleaner history |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Screenshots
Related Issue
Other