Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(refactor) Reorganise styles #68

Merged
merged 1 commit into from
May 3, 2023
Merged

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Apr 28, 2023

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR breaks down the _inputs.scss stylesheet, factoring out the styles into their own stylesheets colocated with their related components and getting rid of some cruft. This should make it easier to refactor styling moving forward, as one would only have to modify the colocated stylesheet file each time they modify a component.

@github-actions
Copy link

github-actions bot commented Apr 28, 2023

Size Change: -30.8 kB (-5%) ✅

Total Size: 546 kB

Filename Size Change
dist/554.js 0 B -32.3 kB (removed) 🏆
ℹ️ View Unchanged
Filename Size Change
dist/225.js 9.82 kB 0 B
dist/272.js 6.59 kB 0 B
dist/290.js 81.1 kB 0 B
dist/294.js 2.63 kB 0 B
dist/366.js 6.94 kB 0 B
dist/591.js 2.96 kB 0 B
dist/595.js 106 kB 0 B
dist/634.js 777 B 0 B
dist/709.js 2.42 kB 0 B
dist/739.js 33.8 kB 0 B
dist/986.js 193 kB 0 B
dist/main.js 97.6 kB +1.57 kB (+2%)
dist/openmrs-form-engine-lib.js 3.24 kB -2 B (0%)

compressed-size-action

Copy link
Member

@samuelmale samuelmale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an amazing effort @denniskigen 🙌 👏

@samuelmale samuelmale merged commit e259674 into main May 3, 2023
@samuelmale samuelmale deleted the refactor/project-structure branch May 3, 2023 16:32
@denniskigen denniskigen mentioned this pull request May 4, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants