Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Fix previous value review UI #70

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented May 4, 2023

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR fixes the appearance of the previous value review UI after a regression following #68. Specifically, it tweaks the styling of the radio field, ensuring that both it and the review UI get enough breathing room. This PR also cleans up a bit of styling cruft and changes some of the wording of elements in the previous value UI.

Screenshots

Before

Screenshot 2023-05-04 at 9 58 30 PM

After

Screenshot 2023-05-04 at 9 56 08 PM

@github-actions
Copy link

github-actions bot commented May 4, 2023

Size Change: -91 B (0%)

Total Size: 546 kB

ℹ️ View Unchanged
Filename Size Change
dist/225.js 9.82 kB 0 B
dist/272.js 6.59 kB 0 B
dist/290.js 81.1 kB 0 B
dist/294.js 2.63 kB 0 B
dist/366.js 6.94 kB 0 B
dist/591.js 2.96 kB 0 B
dist/595.js 106 kB 0 B
dist/634.js 777 B 0 B
dist/709.js 2.42 kB 0 B
dist/739.js 33.8 kB -88 B (0%)
dist/986.js 193 kB 0 B
dist/main.js 97.6 kB -3 B (0%)
dist/openmrs-form-engine-lib.js 3.24 kB 0 B

compressed-size-action

@samuelmale samuelmale merged commit a6fffe4 into main May 4, 2023
@samuelmale samuelmale deleted the fix/previous-value-review-ui branch May 4, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants