Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Leisure -> Movie Theaters -> Auditorium #68

Open
rajrao opened this issue Mar 16, 2021 · 3 comments · May be fixed by #69
Open

Add: Leisure -> Movie Theaters -> Auditorium #68

rajrao opened this issue Mar 16, 2021 · 3 comments · May be fixed by #69
Assignees
@jayshao
Milestone
1.2

Comments

@rajrao
Copy link

rajrao commented Mar 16, 2021

Currently movie theater has only the sub classes of Lobby and Food Court (https://github.com/openooh/venue-taxonomy/blob/main/specification-1.1-draft1.md#leisure-movie-theaters). It would be beneficial to add auditorium as a new item. I believe this is important as the auditorium can display ads that are of higher value and will typically be longer than ones shown in lobbies and food courts. Finally, this part of the spec requires one to use only child types, when they are present:
"No screens should be solely assigned to a parent venue type, unless that parent venue type has no children."
@rajrao rajrao linked a pull request Mar 16, 2021 that will close this issue
Open
@jayshao jayshao changed the title Expand Movie Theaters Add: Leisure -> Movie Theaters -> Auditorium Mar 16, 2021
@jayshao jayshao self-assigned this Mar 16, 2021
@jayshao jayshao added this to the 1.1 milestone Mar 16, 2021
@jayshao jayshao linked a pull request Mar 16, 2021 that will close this issue
Added sub-classification of auditorium to movie theaters #69
Open
@jayshao
Copy link
Contributor

jayshao commented Mar 17, 2021

@rajrao I think this makes sense as an addition. I've queued it up with the rest of the spec working group, and if it gets a couple more +1's we'll see if we can work it into the 1.1 final

@bruno8g
Copy link

bruno8g commented Mar 17, 2021

+1

@jayshao jayshao modified the milestones: 1.1, 1.2 May 11, 2021
@jayshao
Copy link
Contributor

jayshao commented May 11, 2021

Bumping this to 1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jayshao jayshao

Labels
None yet
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Added sub-classification of auditorium to movie theaters rajrao/venue-taxonomy
3 participants
@jayshao @rajrao @bruno8g