Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survival version update #453

Merged
merged 3 commits into from
Aug 7, 2022
Merged

Survival version update #453

merged 3 commits into from
Aug 7, 2022

Conversation

ddsjoberg
Copy link
Collaborator

What changes are proposed in this pull request?

  • Increased minimum version required for the survival package to v3.4-0

NOTE: v3.4-0 is only available on GH at the moment and will be on CRAN soon. To ensure these CI checks pass I added Remotes: therneau/survival to the DESCRIPTION file instructing the install to grab the survival package from GH. We can either merge this PR now and remove this line after survival is on CRAN, or merge it now and just remove this line before the next CRAN release (CRAN doesn't support Remotes:).

If there is an GitHub issue associated with this pull request, please provide link.

closes #451


Checklist for PR reviewer

  • PR branch has pulled the most recent updates from main branch. Ensure the pull request branch and your local version match and both have the latest updates from the main branch.
  • If a new function was added, function should be included in _pkgdown.yml
  • If a bug was fixed, a unit test was added for the bug check
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features. Review coverage with withr::with_envvar(new = c("NOT_CRAN" = "true"), covr::report()). Before you run, begin a fresh R session without any packages loaded.
  • R CMD Check runs without errors, warnings, and notes
  • usethis::use_spell_check() runs with no spelling errors in documentation
  • Has NEWS.md been updated with the changes from this pull request under the heading indicating the latest version. If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • Has the version number been incremented using usethis::use_version(which = "dev")
  • Run devtools::build_readme() to build the README.md file.
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge".

Copy link
Collaborator

@bailliem bailliem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge now picking up the GitHub version, with a note to point to cran prior to next visR release

tests/testthat/test-Surv_CNSR.R Show resolved Hide resolved
@ddsjoberg ddsjoberg merged commit 509bdb2 into main Aug 7, 2022
@ddsjoberg ddsjoberg deleted the survival_version branch August 7, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False error message
2 participants