Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Survival version update #453

Merged
merged 3 commits into from
Aug 7, 2022
Merged

Survival version update #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2903d8c
bump min version of survival
ddsjoberg Aug 6, 2022
f084bd5
Update stat_stepribbon.Rd
ddsjoberg Aug 6, 2022
2100e7b
updated test
ddsjoberg Aug 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Imports:
gtable,
kableExtra,
rlang (>= 1.0.0),
survival,
survival (>= 3.4-0),
tidyr (>= 1.0.0)
Suggests:
covr,
Expand All @@ -57,11 +57,12 @@ Suggests:
tibble,
tidycmprsk (>= 0.1.1),
vdiffr
Remotes: therneau/survival
VignetteBuilder:
knitr
biocViews:
Encoding: UTF-8
Language: en-US
LazyData: true
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.2.0
RoxygenNote: 7.2.1
1 change: 1 addition & 0 deletions man/stat_stepribbon.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 1 addition & 8 deletions tests/testthat/test-Surv_CNSR.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,7 @@ testthat::test_that("T1.2 The function is compatible with the survival package",
testthat::expect_error(survival::survfit(visR::Surv_CNSR(AVAL, CNSR) ~ 1, data = adtte), NA)
testthat::expect_error(survival::survfit(visR::Surv_CNSR(AVAL, CNSR) ~ SEX, data = adtte), NA)

# WHEN THIS TEST FAILS, THAT IS OUR SIGNAL THAT {survival} HAS BEEN UPDATED ON CRAN!!
# AT THAT POINT WE SHOULD DO THE FOLLOWING
# 1. UPDATE THIS UNIT TEST TO ASSURE THERE IS _NO_ ERROR WITH coxph()
# 2. ADD A MIN VERSION REQUIREMENT FOR THE {survival} PACKAGE
# THIS CAN BE DONE IN TWO WAYS:
# 1. in the DESCRIPTION file
# 2. using rlang::check_installed("survival", version = <add required version number>)
testthat::expect_error(survival::coxph(visR::Surv_CNSR() ~ SEX, data = adtte))
testthat::expect_error(survival::coxph(visR::Surv_CNSR() ~ SEX, data = adtte), NA)
bailliem marked this conversation as resolved.
Show resolved Hide resolved
})


Expand Down