FIX: use additional tag on push #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
kmuehlbauer
commented
Aug 14, 2024
| @@ -27,6 +27,9 @@ on: | |||
| permissions: | |||
| contents: read | |||
|
|
|||
| env: | |||
| DOCKER_TAG: pr_68 | |||
There was a problem hiding this comment.
Enter the number of the current pull request.
| @@ -24,6 +24,9 @@ on: | |||
| default: 'true' | |||
| type: string # had a lot of trouble with boolean types, see https://github.com/actions/runner/issues/1483 | |||
|
|
|||
| env: | |||
| DOCKER_TAG: pr_68 | |||
| @@ -1 +1 @@ | |||
| FROM ghcr.io/openradar/erad2024:d6ee5b14f782 | |||
| FROM ghcr.io/openradar/erad2024:pr_68 | |||
There was a problem hiding this comment.
Same here. This will make sure, that the image which is build on push to main is used in subsequent pythia-binder instances.
|
On building the pullrequest image, we see that the tagging worked. Let's check this on push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@openradar/erad2024-team
To keep the pythia-binder up to date, we need to tag the build image with some new tag and use this tag in the
binder/Dockerfile. To be on the safe side, we can apply a tag which corresponds to the PR number.