Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arco data and QVP #97

Merged
merged 30 commits into from
Aug 30, 2024
Merged

Arco data and QVP #97

merged 30 commits into from
Aug 30, 2024

Conversation

aladinor
Copy link
Member

Closes [#53 ]

aladinor and others added 16 commits August 11, 2024 21:00
@aladinor
adding xradar-basics notebook
d867353
@kmuehlbauer
Merge branch 'main' into xradar-basics
c3c8639
@kmuehlbauer
Merge branch 'main' into xradar-basics
e0c7a57
@aladinor
adding xradar-basics notebook
e7c6d14
@aladinor
Merge branch 'openradar:main' into main
df32de2
@aladinor
adding xradar-basics notebook to myst.yml file
861e34e
@aladinor
Merge branch 'xradar-basics' of https://github.com/aladinor/erad2024 …
d645530 
…into xradar-basics

mergin
@aladinor
adding debug lines (similar to openradar#64) in buil-book-pullrequest…
5394a0a 
….yaml file
@aladinor
adding debug lines (similar to openradar#64) in buil-book.yaml file
f63281a
@aladinor
fixing figures
2a9b632
@aladinor
adding images and logos needed for xradar-basics notebook
cba8ea2
@aladinor
Merge branch 'main' into xradar-basics
b726d25
@aladinor
Merge branch 'main' of https://github.com/openradar/erad2024 into arc…
fdc98eb 
…o-data
@aladinor
changing figure path
a2da92e
@aladinor
adding images needed in the Analysis-ready notebooks
67b49f4
@aladinor
adding notebooks
2ca53bc
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 070dc82
✅ Deployment Preview URL: https://openradar.github.io/erad2024/_preview/97

mgrover1
mgrover1 requested changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing @aladinor - one small suggestion, it looks like the link checker is failing on the Marshall Palmer DOI
https://doi.org/10.1175/1520-0469(1948)005%3C0165:TDORWS%3E2.0.CO;2

@aladinor
Copy link
Member Author

@mgrover1, should I put the whole link? I have been trying to find the issue but not sure what is happening...

@mgrover1
Copy link
Contributor

Looks like the link is resolved 👍

mgrover1
mgrover1 requested changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the tags for the image in the CI/binder folder?

@kmuehlbauer
Copy link
Collaborator

Can you add the tags for the image in the CI/binder folder?

I've described the three locations here: #68

@kmuehlbauer
Copy link
Collaborator

@aladinor Please add the tag at the other two locations, too. Thanks!

@aladinor aladinor requested a review from mgrover1 August 30, 2024 14:01
@mgrover1
Copy link
Contributor

Thanks for making all those changes! This looks good to merge 👍

@mgrover1 mgrover1 merged commit 1a7c562 into openradar:main Aug 30, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 30, 2024
@mgrover1 @github-actions
Delete preview for pull request \#97
495148d
@aladinor aladinor changed the title Arco data and VQP Arco data and QVP Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgrover1 mgrover1 mgrover1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aladinor @mgrover1 @kmuehlbauer