Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report missing values #14

Merged
merged 1 commit into from
May 18, 2022
Merged

Conversation

iaindillingham
Copy link
Member

We report the count and percentage of missing values for each column. If the percentage of missing values for a column is 100%, then the column is said to be empty.

Closes #13

We report the count and percentage of missing values for each column. If
the percentage of missing values for a column is 100%, then the column
is said to be empty.

Closes #13
Comment on lines -11 to -23
@pytest.fixture
def dataframe():
return pandas.DataFrame(
{
"patient_id": [1],
"is_registered": [True],
"is_dead": [False],
"stp_code": ["STP0"],
"has_sbp_event": [True],
}
)


Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm being a bit cheeky here and not putting this in a separate commit. Hopefully that's okay 🙂 We stopped using the dataframe fixture several commits ago.

Copy link
Contributor

@robinyjpark robinyjpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@iaindillingham iaindillingham merged commit a11f306 into main May 18, 2022
@iaindillingham iaindillingham deleted the iaindillingham/report-missing-values branch May 18, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report columns that are empty
2 participants