Skip to content

Commit

Permalink
add test ids (#5072) (#5078)
Browse files Browse the repository at this point in the history
(cherry picked from commit 9c192a3)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
  • Loading branch information
3 people authored Sep 26, 2023
1 parent 42db9b5 commit 5a049c9
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ export const DocViewInspectButton = ({ rowIndex }: EuiDataGridCellValueElementPr
onClick={() => setInspectedHit(isCurrentInspected ? undefined : currentInspected)}
iconType={isCurrentInspected ? 'minimize' : 'inspect'}
aria-label={inspectHintMsg}
data-test-subj={`docTableExpandToggleColumn-${rowIndex}`}
/>
</EuiToolTip>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export function DataGridFlyout({
// TODO: replace EuiLink with doc_view_links registry
// TODO: Also move the flyout higher in the react tree to prevent redrawing the table component and slowing down page performance
return (
<EuiFlyout onClose={onClose} size="m">
<EuiFlyout onClose={onClose} size="m" data-test-subj="documentDetailFlyOut">
<EuiFlyoutHeader>
<EuiTitle>
<h2>Document Details</h2>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@ export function DocViewerLinks(renderProps: DocViewLinkRenderProps) {
<EuiFlexGroup gutterSize="m" justifyContent="flexEnd">
{listItems.map((item, index) => (
<EuiFlexItem key={index} grow={false}>
<EuiLink href={item.href} target="_blank" style={{ fontWeight: 'normal' }}>
<EuiLink
href={item.href}
target="_blank"
style={{ fontWeight: 'normal' }}
data-test-subj={item['data-test-subj']}
>
{item.label}
</EuiLink>
</EuiFlexItem>
Expand Down

0 comments on commit 5a049c9

Please sign in to comment.