Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data-test-subj for data explorer cypress test #5072

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Add data-test-subj for data explorer cypress test #5072

merged 1 commit into from
Sep 20, 2023

Conversation

abbyhu2000
Copy link
Member

@abbyhu2000 abbyhu2000 commented Sep 19, 2023 •
edited
Loading

Description

Add some necessary data-test-subj IDs for cypress tests.

Migrate selemium tests to cypress for data explorer PR: opensearch-project/opensearch-dashboards-functional-test#862

Issues Resolved

resolves #5003

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@abbyhu2000
add test ids
d5eefa7 
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
@abbyhu2000 abbyhu2000 mentioned this pull request Sep 19, 2023
Merged
1 task
@abbyhu2000 abbyhu2000 self-assigned this Sep 19, 2023
@abbyhu2000 abbyhu2000 added test:functional data explorer Issues related to the Data Explorer project labels Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023 •
edited
Loading

Codecov Report

Merging #5072 (d5eefa7) into main (b9b2b79) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5072   +/-   ##
=======================================
  Coverage   66.50%   66.50%           
=======================================
  Files        3403     3403           
  Lines       65026    65026           
  Branches    10401    10401           
=======================================
  Hits        43243    43243           
  Misses      19214    19214           
  Partials     2569     2569
Flag Coverage Δ
Linux_1 34.82% <ø> (ø)
Linux_2 55.31% <ø> (ø)
Linux_3 ?
Linux_4 34.89% <ø> (ø)
Windows_1 34.83% <ø> (ø)
Windows_2 55.27% <ø> (ø)
Windows_3 44.61% <ø> (ø)
Windows_4 34.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...n/components/doc_viewer_links/doc_viewer_links.tsx 100.00% <ø> (ø)

@ashwin-pc ashwin-pc added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Sep 20, 2023
@abbyhu2000 abbyhu2000 merged commit 9c192a3 into opensearch-project:main Sep 20, 2023
65 of 70 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 20, 2023
@github-actions
add test ids (#5072)
2e81745 
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit 9c192a3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 20, 2023
Merged
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 21, 2023
@abbyhu2000 @SuZhou-Joe
add test ids (opensearch-project#5072)
ef54a96 
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
kavilla pushed a commit that referenced this pull request Sep 26, 2023
@opensearch-trigger-bot @github-actions @joshuarrrr
add test ids (#5072) (#5078)
5a049c9 
(cherry picked from commit 9c192a3)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
kavilla pushed a commit to opensearch-project/opensearch-dashboards-functional-test that referenced this pull request Oct 13, 2023
@abbyhu2000
Cypress tests for data explorer (#862)
7cf0a03 
Migrate the old selenium tests for discover to cypress tests for data explorer.
PR [for #5003](opensearch-project/OpenSearch-Dashboards#5072) needs to be merged first.

Below are a list of bugs found when writing the tests, the tests for the below feature are skipped and commented with the issue link:

- opensearch-project/OpenSearch-Dashboards#5071
- opensearch-project/OpenSearch-Dashboards#5068
- opensearch-project/OpenSearch-Dashboards#5058
- opensearch-project/OpenSearch-Dashboards#5057
- opensearch-project/OpenSearch-Dashboards#5056

### Issues Resolved
resolves opensearch-project/OpenSearch-Dashboards#4781

---------

Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
opensearch-trigger-bot bot pushed a commit to opensearch-project/opensearch-dashboards-functional-test that referenced this pull request Oct 13, 2023
@abbyhu2000 @github-actions
Cypress tests for data explorer (#862)
58fdd15 
Migrate the old selenium tests for discover to cypress tests for data explorer.
PR [for #5003](opensearch-project/OpenSearch-Dashboards#5072) needs to be merged first.

Below are a list of bugs found when writing the tests, the tests for the below feature are skipped and commented with the issue link:

- opensearch-project/OpenSearch-Dashboards#5071
- opensearch-project/OpenSearch-Dashboards#5068
- opensearch-project/OpenSearch-Dashboards#5058
- opensearch-project/OpenSearch-Dashboards#5057
- opensearch-project/OpenSearch-Dashboards#5056

### Issues Resolved
resolves opensearch-project/OpenSearch-Dashboards#4781

---------

Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
(cherry picked from commit 7cf0a03)
opensearch-trigger-bot bot pushed a commit to opensearch-project/opensearch-dashboards-functional-test that referenced this pull request Oct 13, 2023
@abbyhu2000 @github-actions
Cypress tests for data explorer (#862)
210a28a 
Migrate the old selenium tests for discover to cypress tests for data explorer.
PR [for #5003](opensearch-project/OpenSearch-Dashboards#5072) needs to be merged first.

Below are a list of bugs found when writing the tests, the tests for the below feature are skipped and commented with the issue link:

- opensearch-project/OpenSearch-Dashboards#5071
- opensearch-project/OpenSearch-Dashboards#5068
- opensearch-project/OpenSearch-Dashboards#5058
- opensearch-project/OpenSearch-Dashboards#5057
- opensearch-project/OpenSearch-Dashboards#5056

### Issues Resolved
resolves opensearch-project/OpenSearch-Dashboards#4781

---------

Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
(cherry picked from commit 7cf0a03)
kavilla pushed a commit to opensearch-project/opensearch-dashboards-functional-test that referenced this pull request Oct 13, 2023
@opensearch-trigger-bot @abbyhu2000
Cypress tests for data explorer (#862) (#928)
6492d1f 
Migrate the old selenium tests for discover to cypress tests for data explorer.
PR [for #5003](opensearch-project/OpenSearch-Dashboards#5072) needs to be merged first.

Below are a list of bugs found when writing the tests, the tests for the below feature are skipped and commented with the issue link:

- opensearch-project/OpenSearch-Dashboards#5071
- opensearch-project/OpenSearch-Dashboards#5068
- opensearch-project/OpenSearch-Dashboards#5058
- opensearch-project/OpenSearch-Dashboards#5057
- opensearch-project/OpenSearch-Dashboards#5056

### Issues Resolved
resolves opensearch-project/OpenSearch-Dashboards#4781

---------

Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
(cherry picked from commit 7cf0a03)

Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
kavilla pushed a commit to opensearch-project/opensearch-dashboards-functional-test that referenced this pull request Oct 13, 2023
@opensearch-trigger-bot @abbyhu2000
Cypress tests for data explorer (#862) (#929)
4d39829 
Migrate the old selenium tests for discover to cypress tests for data explorer.
PR [for #5003](opensearch-project/OpenSearch-Dashboards#5072) needs to be merged first.

Below are a list of bugs found when writing the tests, the tests for the below feature are skipped and commented with the issue link:

- opensearch-project/OpenSearch-Dashboards#5071
- opensearch-project/OpenSearch-Dashboards#5068
- opensearch-project/OpenSearch-Dashboards#5058
- opensearch-project/OpenSearch-Dashboards#5057
- opensearch-project/OpenSearch-Dashboards#5056

### Issues Resolved
resolves opensearch-project/OpenSearch-Dashboards#4781

---------

Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
(cherry picked from commit 7cf0a03)

Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@ananzh ananzh ananzh approved these changes

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@seanneumann seanneumann Awaiting requested review from seanneumann

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@BSFishy BSFishy Awaiting requested review from BSFishy

@curq curq Awaiting requested review from curq curq is a code owner

Assignees

@abbyhu2000 abbyhu2000

Labels
backport 2.x data explorer Issues related to the Data Explorer project distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry test:functional v2.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Data Explorer] Add data-test-subject on elements for cypress tests
3 participants
@abbyhu2000 @ashwin-pc @ananzh