-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress tests for data explorer #862
Conversation
92e6842
to
09ffa75
Compare
@@ -0,0 +1,95 @@ | |||
{ | |||
"type": "doc", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can some of this be zipped up?
...ation/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/date_nanos.spec.js
Show resolved
Hide resolved
AWESOME! Will verify later this week. Made some quick comments we should also verify with security enabled. Targetting 2.11? |
yea i think it is targeting 2.11 @ashwin-pc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firstly, really good job with the PR. The tests look good and well written. Im partway though the review by have a general question about cleanup. You are adding a lot of fixtures and changing settings. @kavilla Do you think we need to remove the fixtures after each test/test suite?
...egration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/sidebar.spec.js
Show resolved
Hide resolved
...ation/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/date_nanos.spec.js
Show resolved
Hide resolved
@ashwin-pc that's a good point, the selenium tests would check if load an add them if needed where as some plugins really rely on a fresh state. Perhaps instead of creating a helper function to check and optimize it can be apart of the cypress env variables where it defaults deletes these values after each spec. and we can configure it from our CI to not delete per spec. Another work around (which isn't a catchall) but we ensure the complete uniqueness of the data index created. |
P.S. Dont merge this until |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abbyhu2000 can you add the recordings for these tests to the PR?
...ion/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/shared_links.spec.js
Show resolved
Hide resolved
@kavilla hmm, that seems like that can come as a followup. Want to put some more thought into that. I'm okay with this going in as is for now and following up with improvements to test improvements later when we have a better solution for cleanup. |
@abbyhu2000 @ashwin-pc I think maybe we should consider optimizing the uploading data. Or we start building in the ciGroup stuff since I see this PR increasing the time of the test run: opensearch-project/OpenSearch-Dashboards#5134 (comment). I thought it was failing but I believe it was working just fine just taking a while. (Sorry about the format, i have another PR to fix the formatting issue) |
Wrote a function |
d63f76d
to
17b8d61
Compare
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
9414658
to
ae461ca
Compare
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
5128d68
to
4e4a809
Compare
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
6eda0e0
to
a22eaa6
Compare
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/6504499657 <-- cypress tests pass with ciGroups |
Migrate the old selenium tests for discover to cypress tests for data explorer. PR [for #5003](opensearch-project/OpenSearch-Dashboards#5072) needs to be merged first. Below are a list of bugs found when writing the tests, the tests for the below feature are skipped and commented with the issue link: - opensearch-project/OpenSearch-Dashboards#5071 - opensearch-project/OpenSearch-Dashboards#5068 - opensearch-project/OpenSearch-Dashboards#5058 - opensearch-project/OpenSearch-Dashboards#5057 - opensearch-project/OpenSearch-Dashboards#5056 ### Issues Resolved resolves opensearch-project/OpenSearch-Dashboards#4781 --------- Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> (cherry picked from commit 7cf0a03)
Migrate the old selenium tests for discover to cypress tests for data explorer. PR [for #5003](opensearch-project/OpenSearch-Dashboards#5072) needs to be merged first. Below are a list of bugs found when writing the tests, the tests for the below feature are skipped and commented with the issue link: - opensearch-project/OpenSearch-Dashboards#5071 - opensearch-project/OpenSearch-Dashboards#5068 - opensearch-project/OpenSearch-Dashboards#5058 - opensearch-project/OpenSearch-Dashboards#5057 - opensearch-project/OpenSearch-Dashboards#5056 ### Issues Resolved resolves opensearch-project/OpenSearch-Dashboards#4781 --------- Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> (cherry picked from commit 7cf0a03)
Migrate the old selenium tests for discover to cypress tests for data explorer. PR [for #5003](opensearch-project/OpenSearch-Dashboards#5072) needs to be merged first. Below are a list of bugs found when writing the tests, the tests for the below feature are skipped and commented with the issue link: - opensearch-project/OpenSearch-Dashboards#5071 - opensearch-project/OpenSearch-Dashboards#5068 - opensearch-project/OpenSearch-Dashboards#5058 - opensearch-project/OpenSearch-Dashboards#5057 - opensearch-project/OpenSearch-Dashboards#5056 ### Issues Resolved resolves opensearch-project/OpenSearch-Dashboards#4781 --------- Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> (cherry picked from commit 7cf0a03) Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Migrate the old selenium tests for discover to cypress tests for data explorer. PR [for #5003](opensearch-project/OpenSearch-Dashboards#5072) needs to be merged first. Below are a list of bugs found when writing the tests, the tests for the below feature are skipped and commented with the issue link: - opensearch-project/OpenSearch-Dashboards#5071 - opensearch-project/OpenSearch-Dashboards#5068 - opensearch-project/OpenSearch-Dashboards#5058 - opensearch-project/OpenSearch-Dashboards#5057 - opensearch-project/OpenSearch-Dashboards#5056 ### Issues Resolved resolves opensearch-project/OpenSearch-Dashboards#4781 --------- Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> (cherry picked from commit 7cf0a03) Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Description
This PR migrates the old selenium tests for discover to cypress tests for data explorer.
PR for #5003 needs to be merged first.
Below are a list of bugs found when writing the tests, the tests for the below feature are skipped and commented with the issue link:
data-shared-item
attribute is missing on the discover table OpenSearch-Dashboards#5058SearchOnPageLoad
does not work OpenSearch-Dashboards#5057Issues Resolved
resolves opensearch-project/OpenSearch-Dashboards#4781
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.