Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top Right docViewer linkable plugin injection #1199

Closed
RoyiSitbon opened this issue Feb 2, 2022 · 0 comments · Fixed by #1200
Closed

Top Right docViewer linkable plugin injection #1199

RoyiSitbon opened this issue Feb 2, 2022 · 0 comments · Fixed by #1200
Labels
enhancement New feature or request

Comments

@RoyiSitbon
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, we don't have an option to assimilate links under our top doc view section.
The “view surrounding documents” and “view single document” were written as static content.
We would like to make the top right side under doc view to be pluggable,
in order to assimilate new abilities such as “open in new tab icons” etc.

Before:
injections1

After:
injections2

Describe the solution you'd like
Since we don't find a reason to put something other than links inside this location,
we would like to create a new application component called DocViewerLinks
under dashboards/src/plugins/discover/public/application/components/doc_viewer_links
this component will contain linkable components and will be enriched by other links similarly to the docView tabs logic.

The enriched information will be comprised from:
{ …EuiListGroupItemProps, order: number; generateUrlFn?(renderProps: any): string; }

If we will pass generateUrlFn then we will link the result returned by it, else we will just take the href.

Additional context
After we will have this ability, we will be able to replace
application/angular/doc_table/components/table_row/details.html → link elements, with something like this:

Screen Shot 2022-02-02 at 11 49 44

and enrich links by demand with order prop.

@RoyiSitbon RoyiSitbon added the enhancement New feature or request label Feb 2, 2022
@kavilla kavilla linked a pull request Feb 3, 2022 that will close this issue
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 9, 2022
…ensearch-project#1199)

* fix: legendPath in callbacks gained an additional new element which is a BREAKING CHANGE 
* refactor: exported `HIERARCHY_ROOT_KEY` and also added `NULL_SMALL_MULTIPLES_KEY`
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
…ensearch-project#1199)

* fix: legendPath in callbacks gained an additional new element which is a BREAKING CHANGE 
* refactor: exported `HIERARCHY_ROOT_KEY` and also added `NULL_SMALL_MULTIPLES_KEY`
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
# [31.0.0](elastic/elastic-charts@v30.2.0...v31.0.0) (2021-06-29)

### Bug Fixes

* **xy:** render gridlines behind axis  ([opensearch-project#1204](elastic/elastic-charts#1204)) ([bf9ccbd](elastic/elastic-charts@bf9ccbd)), closes [#1203](elastic/elastic-charts#1203)
* memory leak related to re-reselect cache ([opensearch-project#1201](elastic/elastic-charts#1201)) ([8cb6876](elastic/elastic-charts@8cb6876))
* **partition:** getLegendItemsExtra no longer assumes a singleton ([opensearch-project#1199](elastic/elastic-charts#1199)) ([ecbcc1e](elastic/elastic-charts@ecbcc1e))

### Features

* **annotations:** option to render rect annotations outside chart ([opensearch-project#1207](elastic/elastic-charts#1207)) ([ddffc00](elastic/elastic-charts@ddffc00))
* **heatmap:** enable brushing on categorical charts ([opensearch-project#1212](elastic/elastic-charts#1212)) ([5c426b3](elastic/elastic-charts@5c426b3)), closes [opensearch-project#1170](elastic/elastic-charts#1170) [opensearch-project#1171](elastic/elastic-charts#1171)
* **xy:** add onPointerUpdate debounce and trigger options ([opensearch-project#1194](elastic/elastic-charts#1194)) ([aa068f6](elastic/elastic-charts@aa068f6))

### BREAKING CHANGES

* **xy:** the `PointerOverEvent` type now extends `ProjectedValues` and drops value. This effectively replaces value with `x`, `y`, `smVerticalValue` and `smHorizontalValue`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant