Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nodejs client] fix hookup issues in src/core/server/opensearch #1194

Merged
merged 1 commit into from
Feb 17, 2022
Merged

[nodejs client] fix hookup issues in src/core/server/opensearch #1194

merged 1 commit into from
Feb 17, 2022

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Feb 1, 2022 •
edited by tmarkley
Loading

Description

  1. import Client from '@opensearch-project/opensearch/api/new' to hook
    up the new types
  2. remove asynSearch
  3. apply type assertion
  4. fix undefined and mismatched types

Issues Resolved

Resolves #1193

Partially addresses #837

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@ananzh ananzh requested a review from a team as a code owner February 1, 2022 07:26
@ananzh ananzh mentioned this pull request Feb 1, 2022
Closed
8 tasks
@ananzh ananzh self-assigned this Feb 1, 2022
@ananzh ananzh added nodejs 🍭 issues related to nodejs client v2.0.0 labels Feb 1, 2022
@ananzh ananzh force-pushed the feature/nodejs-opensearch branch from d7f01ed to 4b799c7 Compare February 1, 2022 20:03
@kavilla
Copy link
Member

kavilla commented Feb 2, 2022

remove asyncSearch

Looks asyncSearch was only really used by x-pack plugins correct? So that's why it's safe to remove (especially if only in tests).

@ananzh
Copy link
Member Author

ananzh commented Feb 2, 2022

remove asyncSearch

Looks asyncSearch was only really used by x-pack plugins correct? So that's why it's safe to remove (especially if only in tests).

yeah from my search, it is still a x-pack feature in 7.10

kavilla
kavilla reviewed Feb 3, 2022
View reviewed changes
src/core/server/opensearch/version_check/ensure_opensearch_version.test.ts
@@ -169,7 +169,7 @@ describe('pollOpenSearchNodesVersion', () => {
internalClient.nodes.info.mockImplementationOnce(() => createOpenSearchError(error));
};

it('returns iscCompatible=false and keeps polling when a poll request throws', (done) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@ananzh
[nodejs client] fix hookup issues in src/core/server/opensearch
9e9f2b6 
1. import Client from '@opensearch-project/opensearch/api/new' to hook
up the new types
2. remove asynSearch
3. apply type assertion
4. fix undefined and mismatched types

Remove retry_call_cluster.test.ts due to removing all asyncSearch api

Issue Resolved: opensearch-project#1193
Partical Resolved: opensearch-project#837
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh force-pushed the feature/nodejs-opensearch branch from 4b799c7 to 9e9f2b6 Compare February 7, 2022 22:10
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 9, 2022
@nickofthyme
feat(xy): add onPointerUpdate debounce and trigger options (opensearc…
113a06a 
…h-project#1194)

adds `pointerUpdateDebounce` and `pointerUpdateTrigger` to `Settings` spec to control debounce timing and what value changes trigger the listener. Adds projected values to all `onPointerUpdate` events.

BREAKING CHANGE: the `PointerOverEvent` type now extends `ProjectedValues` and drops value. This effectively replaces value with `x`, `y`, `smVerticalValue` and `smHorizontalValue`.
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@nickofthyme
feat(xy): add onPointerUpdate debounce and trigger options (opensearc…
aa068f6 
…h-project#1194)

adds `pointerUpdateDebounce` and `pointerUpdateTrigger` to `Settings` spec to control debounce timing and what value changes trigger the listener. Adds projected values to all `onPointerUpdate` events.

BREAKING CHANGE: the `PointerOverEvent` type now extends `ProjectedValues` and drops value. This effectively replaces value with `x`, `y`, `smVerticalValue` and `smHorizontalValue`.
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 31.0.0 [skip ci]
bae925c 
# [31.0.0](elastic/elastic-charts@v30.2.0...v31.0.0) (2021-06-29)

### Bug Fixes

* **xy:** render gridlines behind axis  ([opensearch-project#1204](elastic/elastic-charts#1204)) ([bf9ccbd](elastic/elastic-charts@bf9ccbd)), closes [#1203](elastic/elastic-charts#1203)
* memory leak related to re-reselect cache ([opensearch-project#1201](elastic/elastic-charts#1201)) ([8cb6876](elastic/elastic-charts@8cb6876))
* **partition:** getLegendItemsExtra no longer assumes a singleton ([opensearch-project#1199](elastic/elastic-charts#1199)) ([ecbcc1e](elastic/elastic-charts@ecbcc1e))

### Features

* **annotations:** option to render rect annotations outside chart ([opensearch-project#1207](elastic/elastic-charts#1207)) ([ddffc00](elastic/elastic-charts@ddffc00))
* **heatmap:** enable brushing on categorical charts ([opensearch-project#1212](elastic/elastic-charts#1212)) ([5c426b3](elastic/elastic-charts@5c426b3)), closes [opensearch-project#1170](elastic/elastic-charts#1170) [opensearch-project#1171](elastic/elastic-charts#1171)
* **xy:** add onPointerUpdate debounce and trigger options ([opensearch-project#1194](elastic/elastic-charts#1194)) ([aa068f6](elastic/elastic-charts@aa068f6))

### BREAKING CHANGES

* **xy:** the `PointerOverEvent` type now extends `ProjectedValues` and drops value. This effectively replaces value with `x`, `y`, `smVerticalValue` and `smHorizontalValue`.
@kavilla
Copy link
Member

kavilla commented Feb 15, 2022

Can we merge this?

@ananzh ananzh merged commit 9caa9ac into opensearch-project:feature/nodejs Feb 17, 2022
ananzh added a commit that referenced this pull request Mar 5, 2022
@ananzh
[nodejs client] fix hookup issues in src/core/server/opensearch (#1194)
49f8e82 
1. import Client from '@opensearch-project/opensearch/api/new' to hook
up the new types
2. remove asynSearch
3. apply type assertion
4. fix undefined and mismatched types

Remove retry_call_cluster.test.ts due to removing all asyncSearch api

Issue Resolved: #1193
Partical Resolved: #837
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit that referenced this pull request Mar 5, 2022
@ananzh
[nodejs client] fix hookup issues in src/core/server/opensearch (#1194)
c56f149 
1. import Client from '@opensearch-project/opensearch/api/new' to hook
up the new types
2. remove asynSearch
3. apply type assertion
4. fix undefined and mismatched types

Remove retry_call_cluster.test.ts due to removing all asyncSearch api

Issue Resolved: #1193
Partical Resolved: #837
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh deleted the feature/nodejs-opensearch branch September 18, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@tmarkley tmarkley tmarkley approved these changes

Assignees

@ananzh ananzh

Labels
nodejs 🍭 issues related to nodejs client v2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ananzh @kavilla @tmarkley