Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table Visualization][Test] Add unit tests #2856

Closed
ananzh opened this issue Nov 10, 2022 · 3 comments
Closed

[Table Visualization][Test] Add unit tests #2856

ananzh opened this issue Nov 10, 2022 · 3 comments
Assignees
@ananzh
Labels
roadmap tableVis table visualization test:unit v2.7.0 visualizations Issues and PRs related to visualizations

Comments

@ananzh
Copy link
Member

ananzh commented Nov 10, 2022

Should add unit tests using react test library.
@ananzh ananzh added bug Something isn't working untriaged labels Nov 10, 2022
@ananzh ananzh self-assigned this Nov 10, 2022
@ananzh ananzh added tableVis table visualization test:unit v2.5.0 'Issues and PRs related to version v2.5.0' visualizations Issues and PRs related to visualizations and removed bug Something isn't working untriaged labels Nov 10, 2022
@ananzh ananzh removed the v2.5.0 'Issues and PRs related to version v2.5.0' label Dec 16, 2022
@ananzh ananzh mentioned this issue Dec 21, 2022
Merged
8 tasks
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Feb 16, 2023
@ananzh
[Table Visualization] Add unit tests via testing-library and enzyme
093ec4e 
Issue Resolved:
opensearch-project#2856

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh mentioned this issue Feb 16, 2023
Closed
8 tasks
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Feb 17, 2023
@ananzh
[Table Vis][Test] Add unit tests via testing-library and enzyme
af7b6b3 
Issue Resolved:
opensearch-project#2856

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@joshuarrrr joshuarrrr added v2.7.0 and removed v2.6.0 labels Feb 17, 2023
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Feb 21, 2023
@ananzh
[Table Vis][Test] Add unit tests via testing-library and enzyme
a38cffa 
Issue Resolved:
opensearch-project#2856

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 5, 2023
@ananzh
[Table Vis] move format table, consolidate types and add unit tests
1a04a50 
Currently, table data is formatted by a until function convertToFormattedData
in TableVisComponent. In this PR, we moved the formatting data process
to table_vis_response_handler.ts to combine with other data process
logics. In this way, component render and data handling logics are
completely isolated. This PR also solidate some types.

Issue Resolved:
opensearch-project#3395
opensearch-project#2856

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 5, 2023
@ananzh
[Table Vis] move format table, consolidate types and add unit tests
2611e06 
Currently, table data is formatted by a until function convertToFormattedData
in TableVisComponent. In this PR, we moved the formatting data process
to table_vis_response_handler.ts to combine with other data process
logics. In this way, component render and data handling logics are
completely isolated. This PR also solidate some types.

Issue Resolved:
opensearch-project#3395
opensearch-project#2856

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 14, 2023
@ananzh
[Table Vis] move format table, consolidate types and add unit tests
49ca86c 
Currently, table data is formatted by a until function convertToFormattedData
in TableVisComponent. In this PR, we moved the formatting data process
to table_vis_response_handler.ts to combine with other data process
logics. In this way, component render and data handling logics are
completely isolated. This PR also solidate some types.

Issue Resolved:
opensearch-project#3395
opensearch-project#2856

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 14, 2023
@ananzh
[Table Vis] move format table, consolidate types and add unit tests
2e44c2f 
Currently, table data is formatted by a until function convertToFormattedData
in TableVisComponent. In this PR, we moved the formatting data process
to table_vis_response_handler.ts to combine with other data process
logics. In this way, component render and data handling logics are
completely isolated. This PR also solidate some types.

Issue Resolved:
opensearch-project#3395
opensearch-project#2856

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@joshuarrrr
Copy link
Member

@ananzh Will this issue be resolved by #3397 ?

ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 17, 2023
@ananzh
[Table Vis] move format table, consolidate types and add unit tests
e9e9f46 
Currently, table data is formatted by a until function convertToFormattedData
in TableVisComponent. In this PR, we moved the formatting data process
to table_vis_response_handler.ts to combine with other data process
logics. In this way, component render and data handling logics are
completely isolated. This PR also solidate some types.

Issue Resolved:
opensearch-project#3395
opensearch-project#2856

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
joshuarrrr pushed a commit that referenced this issue Apr 17, 2023
@ananzh
[Table Vis] move format table, consolidate types and add unit tests (#…
fc195ea 
…3397)

Currently, table data is formatted by a until function convertToFormattedData
in TableVisComponent. In this PR, we moved the formatting data process
to table_vis_response_handler.ts to combine with other data process
logics. In this way, component render and data handling logics are
completely isolated. This PR also solidate some types.

Issue Resolved:
#3395
#2856

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh
Copy link
Member Author

ananzh commented Apr 17, 2023

unit tests are added. close this issue.

@ananzh ananzh closed this as completed Apr 17, 2023
@joshuarrrr
Copy link
Member

completed via #3397

ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 17, 2023
@ananzh
[Table Vis] move format table, consolidate types and add unit tests
02385a5 
Currently, table data is formatted by a until function convertToFormattedData
in TableVisComponent. In this PR, we moved the formatting data process
to table_vis_response_handler.ts to combine with other data process
logics. In this way, component render and data handling logics are
completely isolated. This PR also solidate some types.

Issue Resolved:
opensearch-project#3395
opensearch-project#2856

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 17, 2023
@ananzh
[2.x Backport][Table Vis] move format table, consolidate types and ad…
3a7fbe7 
…d unit tests

Currently, table data is formatted by a until function convertToFormattedData
in TableVisComponent. In this PR, we moved the formatting data process
to table_vis_response_handler.ts to combine with other data process
logics. In this way, component render and data handling logics are
completely isolated. This PR also solidate some types.

Backport PR:
opensearch-project#3397

Issue Resolved:
opensearch-project#3395
opensearch-project#2856

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh mentioned this issue Apr 17, 2023
Merged
8 tasks
ashwin-pc pushed a commit that referenced this issue Apr 18, 2023
@ananzh
[2.x Backport][Table Vis] move format table, consolidate types and ad…
eb0a315 
…d unit tests (#3869)

Currently, table data is formatted by a until function convertToFormattedData
in TableVisComponent. In this PR, we moved the formatting data process
to table_vis_response_handler.ts to combine with other data process
logics. In this way, component render and data handling logics are
completely isolated. This PR also solidate some types.

Backport PR:
#3397

Issue Resolved:
#3395
#2856

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ananzh ananzh

Labels
roadmap tableVis table visualization test:unit v2.7.0 visualizations Issues and PRs related to visualizations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshuarrrr @ananzh