Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table Visualization] move format table logic to table render to completely isolate data handling logic #3395

Closed
ananzh opened this issue Feb 7, 2023 · 0 comments · Fixed by #3397
Closed

[Table Visualization] move format table logic to table render to completely isolate data handling logic #3395

ananzh opened this issue Feb 7, 2023 · 0 comments · Fixed by #3397
Assignees
@ananzh
Labels
enhancement New feature or request tableVis table visualization v2.7.0

Comments

@ananzh
Copy link
Member

ananzh commented Feb 7, 2023

Currently, table data is formatted by a until function convertToFormattedData which is called in TableVisComponent here.

Ideally, the data formatting should be in table_vis_response_handler.ts with all data processing handling processes. It should not be in the table vis component.

This can help to completely isolate data handling logic from rendering logic.
@ananzh ananzh added enhancement New feature or request v2.6.0 labels Feb 7, 2023
@ananzh ananzh self-assigned this Feb 7, 2023
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Feb 8, 2023
@ananzh
[Table Vis] move format table logic to table render and solidate types
8f7ceab 
Currently, table data is formatted by a until function convertToFormattedData
in TableVisComponent. In this PR, we moved the formatting data process
to table_vis_response_handler.ts to combine with other data process
logics. In this way, component render and data handling logics are
completely isolated. This PR also solidate some types.

Issue Resolved:
opensearch-project#3395

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh mentioned this issue Feb 8, 2023
Merged
8 tasks
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Feb 8, 2023
@ananzh
[Table Vis] move format table logic to table render and solidate types
2783572 
Currently, table data is formatted by a until function convertToFormattedData
in TableVisComponent. In this PR, we moved the formatting data process
to table_vis_response_handler.ts to combine with other data process
logics. In this way, component render and data handling logics are
completely isolated. This PR also solidate some types.

Issue Resolved:
opensearch-project#3395

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@joshuarrrr joshuarrrr added v2.7.0 and removed v2.6.0 labels Feb 17, 2023
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Feb 20, 2023
@ananzh
[Table Vis] move format table logic to table render and solidate types
f027d3f 
Currently, table data is formatted by a until function convertToFormattedData
in TableVisComponent. In this PR, we moved the formatting data process
to table_vis_response_handler.ts to combine with other data process
logics. In this way, component render and data handling logics are
completely isolated. This PR also solidate some types.

Issue Resolved:
opensearch-project#3395

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@joshuarrrr joshuarrrr added the tableVis table visualization label Mar 23, 2023
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 5, 2023
@ananzh
[Table Vis] move format table, consolidate types and add unit tests
1a04a50 
Currently, table data is formatted by a until function convertToFormattedData
in TableVisComponent. In this PR, we moved the formatting data process
to table_vis_response_handler.ts to combine with other data process
logics. In this way, component render and data handling logics are
completely isolated. This PR also solidate some types.

Issue Resolved:
opensearch-project#3395
opensearch-project#2856

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 5, 2023
@ananzh
[Table Vis] move format table, consolidate types and add unit tests
2611e06 
Currently, table data is formatted by a until function convertToFormattedData
in TableVisComponent. In this PR, we moved the formatting data process
to table_vis_response_handler.ts to combine with other data process
logics. In this way, component render and data handling logics are
completely isolated. This PR also solidate some types.

Issue Resolved:
opensearch-project#3395
opensearch-project#2856

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 14, 2023
@ananzh
[Table Vis] move format table, consolidate types and add unit tests
49ca86c 
Currently, table data is formatted by a until function convertToFormattedData
in TableVisComponent. In this PR, we moved the formatting data process
to table_vis_response_handler.ts to combine with other data process
logics. In this way, component render and data handling logics are
completely isolated. This PR also solidate some types.

Issue Resolved:
opensearch-project#3395
opensearch-project#2856

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 14, 2023
@ananzh
[Table Vis] move format table, consolidate types and add unit tests
2e44c2f 
Currently, table data is formatted by a until function convertToFormattedData
in TableVisComponent. In this PR, we moved the formatting data process
to table_vis_response_handler.ts to combine with other data process
logics. In this way, component render and data handling logics are
completely isolated. This PR also solidate some types.

Issue Resolved:
opensearch-project#3395
opensearch-project#2856

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 17, 2023
@ananzh
[Table Vis] move format table, consolidate types and add unit tests
e9e9f46 
Currently, table data is formatted by a until function convertToFormattedData
in TableVisComponent. In this PR, we moved the formatting data process
to table_vis_response_handler.ts to combine with other data process
logics. In this way, component render and data handling logics are
completely isolated. This PR also solidate some types.

Issue Resolved:
opensearch-project#3395
opensearch-project#2856

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
joshuarrrr pushed a commit that referenced this issue Apr 17, 2023
@ananzh
[Table Vis] move format table, consolidate types and add unit tests (#…
fc195ea 
…3397)

Currently, table data is formatted by a until function convertToFormattedData
in TableVisComponent. In this PR, we moved the formatting data process
to table_vis_response_handler.ts to combine with other data process
logics. In this way, component render and data handling logics are
completely isolated. This PR also solidate some types.

Issue Resolved:
#3395
#2856

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 17, 2023
@ananzh
[Table Vis] move format table, consolidate types and add unit tests
02385a5 
Currently, table data is formatted by a until function convertToFormattedData
in TableVisComponent. In this PR, we moved the formatting data process
to table_vis_response_handler.ts to combine with other data process
logics. In this way, component render and data handling logics are
completely isolated. This PR also solidate some types.

Issue Resolved:
opensearch-project#3395
opensearch-project#2856

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 17, 2023
@ananzh
[2.x Backport][Table Vis] move format table, consolidate types and ad…
3a7fbe7 
…d unit tests

Currently, table data is formatted by a until function convertToFormattedData
in TableVisComponent. In this PR, we moved the formatting data process
to table_vis_response_handler.ts to combine with other data process
logics. In this way, component render and data handling logics are
completely isolated. This PR also solidate some types.

Backport PR:
opensearch-project#3397

Issue Resolved:
opensearch-project#3395
opensearch-project#2856

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh mentioned this issue Apr 17, 2023
Merged
8 tasks
ashwin-pc pushed a commit that referenced this issue Apr 18, 2023
@ananzh
[2.x Backport][Table Vis] move format table, consolidate types and ad…
eb0a315 
…d unit tests (#3869)

Currently, table data is formatted by a until function convertToFormattedData
in TableVisComponent. In this PR, we moved the formatting data process
to table_vis_response_handler.ts to combine with other data process
logics. In this way, component render and data handling logics are
completely isolated. This PR also solidate some types.

Backport PR:
#3397

Issue Resolved:
#3395
#2856

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ananzh ananzh

Labels
enhancement New feature or request tableVis table visualization v2.7.0
Projects
None yet
Milestone
No milestone
2 participants
@joshuarrrr @ananzh