Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] set-output is deprecated #5322

Closed
abbyhu2000 opened this issue Oct 18, 2023 · 1 comment · Fixed by #5340
Closed

[CI] set-output is deprecated #5322

abbyhu2000 opened this issue Oct 18, 2023 · 1 comment · Fixed by #5340
Labels
ci good first issue Good for newcomers

Comments

@abbyhu2000
Copy link
Member

abbyhu2000 commented Oct 18, 2023 •
edited
Loading

Describe the bug

Our github action is complaining the following:

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

We use set-output to set environment variables; maybe we can upgrade to using environment files as suggested above here: https://github.com/opensearch-project/OpenSearch-Dashboards/tree/466d298d673bf3d46acecf39a04ed6501d9ac960/.github/workflows

To Reproduce

Here is one example github action run:
https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/6540904090?pr=5300
@abbyhu2000 abbyhu2000 added good first issue Good for newcomers ci labels Oct 18, 2023
This was referenced Oct 19, 2023
Closed
Closed
Merged
vvavdiya added a commit to vvavdiya/OpenSearch-Dashboards that referenced this issue Oct 23, 2023
@vvavdiya @joshuarrrr
Updated CHANGELOG.md for opensearch-project#5322 [CI] Replace usage o…
e0b0f23 
…f deprecated `set-output` in workflows

Co-authored-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Vijay Vavdiya <vijayvavdiya@gmail.com>
@kavilla kavilla linked a pull request Oct 23, 2023 that will close this issue
[OSCI][CI] set-output is deprecated #5340
Merged
7 tasks
kavilla pushed a commit that referenced this issue Oct 27, 2023
@vvavdiya @joshuarrrr
[OSCI][CI] replace deprecated set-output (#5340)
8d8de0a 
set-output command for workflows is deprecated according to Github documentation. Update done using GITHUB_OUTPUT environment files. More details here:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/#examples

Issues Resolved
#5322

* replaced set-output
* CI replaced set-output
* Updated CHANGELOG.md for #5322 [CI] Replace usage of deprecated `set-output` in workflows

Signed-off-by: Vijay Vavdiya <vijayvavdiya@gmail.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
@kavilla
Copy link
Member

kavilla commented Oct 27, 2023

@vvavdiya can you comment on this issue so I can have it assigned for you.

opensearch-trigger-bot bot pushed a commit that referenced this issue Oct 27, 2023
@github-actions
[OSCI][CI] replace deprecated set-output (#5340)
1a74a72 
set-output command for workflows is deprecated according to Github documentation. Update done using GITHUB_OUTPUT environment files. More details here:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/#examples

Issues Resolved
#5322

* replaced set-output
* CI replaced set-output
* Updated CHANGELOG.md for #5322 [CI] Replace usage of deprecated `set-output` in workflows

Signed-off-by: Vijay Vavdiya <vijayvavdiya@gmail.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 8d8de0a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
opensearch-trigger-bot bot pushed a commit that referenced this issue Oct 27, 2023
@github-actions
[OSCI][CI] replace deprecated set-output (#5340)
b80f6c5 
set-output command for workflows is deprecated according to Github documentation. Update done using GITHUB_OUTPUT environment files. More details here:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/#examples

Issues Resolved
#5322

* replaced set-output
* CI replaced set-output
* Updated CHANGELOG.md for #5322 [CI] Replace usage of deprecated `set-output` in workflows

Signed-off-by: Vijay Vavdiya <vijayvavdiya@gmail.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 8d8de0a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
joshuarrrr pushed a commit that referenced this issue Nov 7, 2023
@opensearch-trigger-bot @github-actions
[OSCI][CI] replace deprecated set-output (#5340) (#5380)
64f9f1a 
set-output command for workflows is deprecated according to Github documentation. Update done using GITHUB_OUTPUT environment files. More details here:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/#examples

Issues Resolved
#5322

* replaced set-output
* CI replaced set-output
* Updated CHANGELOG.md for #5322 [CI] Replace usage of deprecated `set-output` in workflows

Signed-off-by: Vijay Vavdiya <vijayvavdiya@gmail.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 8d8de0a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[OSCI][CI] set-output is deprecated vvavdiya/OpenSearch-Dashboards
2 participants
@kavilla @abbyhu2000