[OSCI][CI] set-output is deprecated

[vvavdiya]

Description

set-output command for workflows is deprecated according to Github documentation. Update done using GITHUB_OUTPUT environment files. More details here.

Issues Resolved

#5322

Screenshot

Run cypress tests

https://github.com/vvavdiya/OpenSearch-Dashboards/actions/runs/6574727075/job/17864788175#logs

Testing the changes

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[vvavdiya]

@abbyhu2000
PR available for review. I have have replaced deprecated set-output as mentioned following guideline

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/#examples

[codecov]

Codecov Report

Merging #5340 (e0b0f23) into main (e1db842) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5340   +/-   ##
=======================================
  Coverage   66.81%   66.81%           
=======================================
  Files        3286     3286           
  Lines       63148    63148           
  Branches    10054    10054           
=======================================
  Hits        42191    42191           
  Misses      18475    18475           
  Partials     2482     2482           

Flag	Coverage Δ
Linux_1	35.24% <ø> (ø)
Linux_2	55.25% <ø> (ø)
Linux_3	43.82% <ø> (ø)
Linux_4	35.34% <ø> (ø)
Windows_1	35.25% <ø> (ø)
Windows_2	55.22% <ø> (ø)
Windows_3	43.83% <ø> (ø)
Windows_4	35.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[joshuarrrr]

Thanks @vvavdiya , looks good to me, although other maintainers are more familiar with GH workflows.

[willie-hung]

LGTM too!

[BigSamu]

LGTM! Although I recommend further explaining what your solution was in the description section of PR. It seems a bit vague at least for me this:

Description
[CI] set-output is deprecated

Better would be

set-output command for workflows is deprecated according to Github documentation. Update done using GITHUB_OUTPUT environment files. More details here.

[kavilla]

LGTM! Although I recommend further explaining what your solution was in the description section of PR. It seems a bit vague at least for me this:

Description [CI] set-output is deprecated

Better would be

set-output command for workflows is deprecated according to Github documentation. Update done using GITHUB_OUTPUT environment files. More details here.

<3 Thank you a lot @BigSamu. A great call out as it is important because this project utilizes GitHub but not every fork of this repo utilizes GitHub. So each commit be able to communicate it's change to users of git. Related: https://forum.opensearch.org/t/missing-commit-messages-and-changelogs/6223.

Also, thank you so much @vvavdiya! A lot less warning messages now. I see the check link action still is outputting that warning. Did we want to update that as well or would you like to do it in a follow up PR? I'm fine with this as is but if it's quick enough would be better to get it in one go

[vvavdiya]

LGTM! Although I recommend further explaining what your solution was in the description section of PR. It seems a bit vague at least for me this:

Description [CI] set-output is deprecated

Better would be

set-output command for workflows is deprecated according to Github documentation. Update done using GITHUB_OUTPUT environment files. More details here.

Updated the descriptions with more explanation..

[vvavdiya]

LGTM! Although I recommend further explaining what your solution was in the description section of PR. It seems a bit vague at least for me this:
Description [CI] set-output is deprecated
Better would be
set-output command for workflows is deprecated according to Github documentation. Update done using GITHUB_OUTPUT environment files. More details here.

<3 Thank you a lot @BigSamu. A great call out as it is important because this project utilizes GitHub but not every fork of this repo utilizes GitHub. So each commit be able to communicate it's change to users of git. Related: https://forum.opensearch.org/t/missing-commit-messages-and-changelogs/6223.

Also, thank you so much @vvavdiya! A lot less warning messages now. I see the check link action still is outputting that warning. Did we want to update that as well or would you like to do it in a follow up PR? I'm fine with this as is but if it's quick enough would be better to get it in one go

@kavilla Thanks for your review.
can you please help me with more details/context of the issue? so i can take it in follow up PR.

[BigSamu]

LGTM

[CMDWillYang]

LGTM as well!

[kavilla]

LGTM! Although I recommend further explaining what your solution was in the description section of PR. It seems a bit vague at least for me this:
Description [CI] set-output is deprecated
Better would be
set-output command for workflows is deprecated according to Github documentation. Update done using GITHUB_OUTPUT environment files. More details here.

<3 Thank you a lot @BigSamu. A great call out as it is important because this project utilizes GitHub but not every fork of this repo utilizes GitHub. So each commit be able to communicate it's change to users of git. Related: https://forum.opensearch.org/t/missing-commit-messages-and-changelogs/6223.
Also, thank you so much @vvavdiya! A lot less warning messages now. I see the check link action still is outputting that warning. Did we want to update that as well or would you like to do it in a follow up PR? I'm fine with this as is but if it's quick enough would be better to get it in one go

@kavilla Thanks for your review. can you please help me with more details/context of the issue? so i can take it in follow up PR.

Oh I see, I think it is related to the actual github action we are using for checking links. The action might have an available upgrade that handles this deprecation.

But that's outside this issue.

Thank you!