-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Running yarn uiFramework:start
fails to build osd-ui-framework
#680
Comments
I confirmed that |
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this issue
Aug 25, 2021
Allowing for the following builds to complete successfully: * `yarn build:types` * `yarn uiFramework:build` * `yarn uiFramework:start` Not positive about the expected results when running uiFramework:start but it seems to be on par with the legacy 7.10.2 version. Issue resolved: opensearch-project#680 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this issue
Aug 25, 2021
Allowing for the following builds to complete successfully: * `yarn build:types` * `yarn uiFramework:build` * `yarn uiFramework:start` Not positive about the expected results when running uiFramework:start but it seems to be on par with the legacy 7.10.2 version. Issue resolved: opensearch-project#680 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
5 tasks
5 tasks
kavilla
added a commit
that referenced
this issue
Aug 31, 2021
Allowing for the following builds to complete successfully: * `yarn build:types` * `yarn uiFramework:build` * `yarn uiFramework:start` Not positive about the expected results when running uiFramework:start but it seems to be on par with the legacy 7.10.2 version. Issue resolved: #680 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this issue
Aug 31, 2021
Allowing for the following builds to complete successfully: * `yarn build:types` * `yarn uiFramework:build` * `yarn uiFramework:start` Not positive about the expected results when running uiFramework:start but it seems to be on par with the legacy 7.10.2 version. Issue resolved: opensearch-project#680 Backport PR: opensearch-project#734 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
that referenced
this issue
Aug 31, 2021
Allowing for the following builds to complete successfully: * `yarn build:types` * `yarn uiFramework:build` * `yarn uiFramework:start` Not positive about the expected results when running uiFramework:start but it seems to be on par with the legacy 7.10.2 version. Issue resolved: #680 Backport PR: #734 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The package
osd-ui-framework
does not build on runningyarn uiFramework:start
. The biggest issue here seems to be that the dependencies were updated but the docsite build was not run since the update.react-router
was updated from 3 to 4 which was a complete rewrite of the package causing a lot of breaking changes. There are a few other issue which make the build fail as well.packages/osd-ui-framework/doc_site/webpack.config.js
file uses the post-css loader but that file now resides inpackages/osd-optimizer/postcss.config.js
(As a part of this migration: Link). Updating the rule should fix this.These are the 3 main issues i've identified but there may be more. Migrating the router is what held me off from just jumping in and fixing this.
To Reproduce
Steps to reproduce the behavior:
yarn uiFramework:start
Expected behavior
Expected the server to start and load the components
OpenSearch Version
1.0.0
Dashboards Version
1.0.0
Plugins
Please list all plugins currently enabled.
Screenshots
If applicable, add screenshots to help explain your problem.
Host/Environment (please complete the following information):
Additional context
This package seems to host many UI components, but i cant seem to find any references to it within the actual application.
The text was updated successfully, but these errors were encountered: