[1.x][Build] build:types and uiFramework run successfully #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowing for the following builds to complete successfully: * `yarn build:types` * `yarn uiFramework:build` * `yarn uiFramework:start` Not positive about the expected results when running uiFramework:start but it seems to be on par with the legacy 7.10.2 version. Issue resolved: opensearch-project#680 Backport PR: opensearch-project#734 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
|
✅ DCO Check Passed 40e2953 |
tmarkley
approved these changes
Aug 31, 2021
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
…ject#848) This fix reduces the situation where a drag event is fired instead of a click one. It adds the following thresholds: - a 100ms threshold before the mouse-down time and the current time to consider the movement for dragging purposes - a 4-pixel delta between mouse-down and the current position to consider the movement for dragging purposes fix opensearch-project#748
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [23.2.0](elastic/elastic-charts@v23.1.1...v23.2.0) (2020-10-06) ### Bug Fixes * **heatmap:** adjust pageSize based available chart height ([opensearch-project#849](elastic/elastic-charts#849)) ([fd56099](elastic/elastic-charts@fd56099)) * **heatmap:** destroy canvas bbox calculator when done ([opensearch-project#844](elastic/elastic-charts#844)) ([4c1fd55](elastic/elastic-charts@4c1fd55)) * **heatmap:** x-axis labels overlapping for time series data ([opensearch-project#850](elastic/elastic-charts#850)) ([7cbd151](elastic/elastic-charts@7cbd151)) * **interactions:** recognise drag after 100ms and 4px ([opensearch-project#848](elastic/elastic-charts#848)) ([f7aa7f8](elastic/elastic-charts@f7aa7f8)), closes [opensearch-project#748](elastic/elastic-charts#748) ### Features * heatmap tooltip enhancements and fixes ([opensearch-project#847](elastic/elastic-charts#847)) ([6d763fb](elastic/elastic-charts@6d763fb))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing for the following builds to complete successfully:
yarn build:typesyarn uiFramework:buildyarn uiFramework:startNot positive about the expected results when running uiFramework:start
but it seems to be on par with the legacy 7.10.2 version.
Issue resolved:
#680
Backport PR:
#734
Signed-off-by: Kawika Avilla kavilla414@gmail.com