Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MD] UX enhancement for datasource #2529

Closed
wants to merge 2 commits into from

Conversation

yibow98
Copy link
Contributor

@yibow98 yibow98 commented Oct 7, 2022

Signed-off-by: Yibo Wang yibow@amazon.com

Description

This PR is new version of #2501. Previous pr's commit are messy due to merge conflict.

  1. Addressed all the comments from previous pr
  2. Update snapshots and unit tests accordingly

Screen Shot 2022-10-07 at 12 24 10 AM

Issues Resolved

opensearch-project/ux#19
opensearch-project/ux#23
opensearch-project/ux#24
opensearch-project/ux#25
opensearch-project/ux#26
opensearch-project/ux#29
#2434
#2439

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Yibo Wang <yibow@amazon.com>
@yibow98 yibow98 requested a review from a team as a code owner October 7, 2022 07:25
Signed-off-by: Yibo Wang <yibow@amazon.com>
@yibow98 yibow98 added v2.4.0 'Issues and PRs related to version v2.4.0' multiple datasource multiple datasource project ux / ui Improvements or additions to user experience, flows, components, UI elements backport 2.x labels Oct 7, 2022
@yibow98 yibow98 self-assigned this Oct 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2022

Codecov Report

Merging #2529 (2d700ac) into main (0e742b9) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2529      +/-   ##
==========================================
- Coverage   66.75%   66.74%   -0.01%     
==========================================
  Files        3201     3202       +1     
  Lines       60948    60958      +10     
  Branches     9267     9267              
==========================================
+ Hits        40683    40689       +6     
- Misses      18050    18052       +2     
- Partials     2215     2217       +2     
Impacted Files Coverage Δ
src/core/public/doc_links/doc_links_service.ts 100.00% <ø> (ø)
...components/create_form/create_data_source_form.tsx 83.60% <100.00%> (+0.27%) ⬆️
...te_data_source_wizard/components/header/header.tsx 100.00% <100.00%> (ø)
...ent/public/components/text_content/text_content.ts 100.00% <100.00%> (ø)
...nent/experimental_callout/experimental_callout.tsx 100.00% <100.00%> (ø)
...ic/application/models/sense_editor/sense_editor.ts 64.00% <0.00%> (-1.78%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@seraphjiang
Copy link
Member

Thanks @yibow98 , great work
Could we also add @KrooshalUX to reviewers

@yibow98
Copy link
Contributor Author

yibow98 commented Oct 7, 2022

Thanks @yibow98 , great work Could we also add @KrooshalUX to reviewers

Sure! Added.

@seraphjiang
Copy link
Member

btw, what block us to convert #2501 from draft to official PR? permission?

@yibow98
Copy link
Contributor Author

yibow98 commented Oct 7, 2022

btw, what block us to convert #2501 from draft to official PR? permission?

I convert #2501 to draft by myself since the commit history is not correct and will be some problem if that PR merge to Main. That's the reason I create a new PR instead of using previous. Once this PR is merged, I will close that previous PR as soon as possible.

@yibow98 yibow98 closed this Oct 7, 2022
@AMoo-Miki AMoo-Miki removed the v2.4.0 'Issues and PRs related to version v2.4.0' label Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x multiple datasource multiple datasource project ux / ui Improvements or additions to user experience, flows, components, UI elements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants