-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance the Build and Test workflow #3299
Conversation
086cc16
to
c9ede11
Compare
Codecov Report
@@ Coverage Diff @@
## 1.x #3299 +/- ##
======================================
Coverage ? 67.49%
======================================
Files ? 3044
Lines ? 58696
Branches ? 8902
======================================
Hits ? 39617
Misses ? 16931
Partials ? 2148
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
502c33f
to
80c174d
Compare
* Run GitHub workflow unit tests in band (opensearch-project#1306) * Fix JUnit Reporter test (opensearch-project#1338) * Add src/test_utils/ and src/core paths to the target clean patterns (opensearch-project#1442) * Add code coverage reporting (opensearch-project#1478) * Add release build verification workflow (opensearch-project#1502) * Add Windows CI to the workflow (opensearch-project#2966) * Add retrying flaky jest tests (opensearch-project#2967) * Record functional test artifacts in case of failure (opensearch-project#3190) * Increase timeout waiting for the exiting of an optimizer worker (opensearch-project#3193) * Improve yarn's performance in workflows by caching yarn's cache folder (opensearch-project#3194) * Fix the version of Chrome to 107 to match `chromedriver@107.0.1`, the last that works on NodeJS v10 * Prevent `AbortError` from breaking unit tests for ExecutionContract Signed-off-by: Miki <miki@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of changes here, but nothing of concern jumped out at me. It will be a huge improvement to bring these workflows and tests more inline with our other branches.
While this has passed several times in the past, on Windows this PR has failed twice with
Wish I knew where that was coming from. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-3299-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1c1ea7ca9c2b3697e469e2f5b588d0ce3d51ee08
# Push it to GitHub
git push --set-upstream origin backport/backport-3299-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.3 Then, create a pull request where the |
Nice! With the retry and increasing of timeout it enables us to run the CI at full speed without capping it to prevent failures. |
i'll manually backport this. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-3299-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1c1ea7ca9c2b3697e469e2f5b588d0ce3d51ee08
# Push it to GitHub
git push --set-upstream origin backport/backport-3299-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.3 Then, create a pull request where the |
…ject#3299) * Run GitHub workflow unit tests in band (opensearch-project#1306) * Fix JUnit Reporter test (opensearch-project#1338) * Add src/test_utils/ and src/core paths to the target clean patterns (opensearch-project#1442) * Add code coverage reporting (opensearch-project#1478) * Add release build verification workflow (opensearch-project#1502) * Add Windows CI to the workflow (opensearch-project#2966) * Add retrying flaky jest tests (opensearch-project#2967) * Record functional test artifacts in case of failure (opensearch-project#3190) * Increase timeout waiting for the exiting of an optimizer worker (opensearch-project#3193) * Improve yarn's performance in workflows by caching yarn's cache folder (opensearch-project#3194) * Fix the version of Chrome to 107 to match `chromedriver@107.0.1`, the last that works on NodeJS v10 * Prevent `AbortError` from breaking unit tests for ExecutionContract Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Miki <amoo_miki@yahoo.com>
…ject#3299) * Run GitHub workflow unit tests in band (opensearch-project#1306) * Fix JUnit Reporter test (opensearch-project#1338) * Add src/test_utils/ and src/core paths to the target clean patterns (opensearch-project#1442) * Add code coverage reporting (opensearch-project#1478) * Add release build verification workflow (opensearch-project#1502) * Add Windows CI to the workflow (opensearch-project#2966) * Add retrying flaky jest tests (opensearch-project#2967) * Record functional test artifacts in case of failure (opensearch-project#3190) * Increase timeout waiting for the exiting of an optimizer worker (opensearch-project#3193) * Improve yarn's performance in workflows by caching yarn's cache folder (opensearch-project#3194) * Fix the version of Chrome to 107 to match `chromedriver@107.0.1`, the last that works on NodeJS v10 * Prevent `AbortError` from breaking unit tests for ExecutionContract Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Miki <amoo_miki@yahoo.com>
* Run GitHub workflow unit tests in band (opensearch-project#1306) * Fix JUnit Reporter test (opensearch-project#1338) * Add src/test_utils/ and src/core paths to the target clean patterns (opensearch-project#1442) * Add code coverage reporting (opensearch-project#1478) * Add release build verification workflow (opensearch-project#1502) * Add Windows CI to the workflow (opensearch-project#2966) * Add retrying flaky jest tests (opensearch-project#2967) * Record functional test artifacts in case of failure (opensearch-project#3190) * Increase timeout waiting for the exiting of an optimizer worker (opensearch-project#3193) * Improve yarn's performance in workflows by caching yarn's cache folder (opensearch-project#3194) * Fix the version of Chrome to 107 to match `chromedriver@107.0.1`, the last that works on NodeJS v10 * Prevent `AbortError` from breaking unit tests for ExecutionContract Backport PR: opensearch-project#3299 Signed-off-by: Miki <miki@amazon.com>
* Run GitHub workflow unit tests in band (#1306) * Fix JUnit Reporter test (#1338) * Add src/test_utils/ and src/core paths to the target clean patterns (#1442) * Add code coverage reporting (#1478) * Add release build verification workflow (#1502) * Add Windows CI to the workflow (#2966) * Add retrying flaky jest tests (#2967) * Record functional test artifacts in case of failure (#3190) * Increase timeout waiting for the exiting of an optimizer worker (#3193) * Improve yarn's performance in workflows by caching yarn's cache folder (#3194) * Fix the version of Chrome to 107 to match `chromedriver@107.0.1`, the last that works on NodeJS v10 * Prevent `AbortError` from breaking unit tests for ExecutionContract Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Miki <amoo_miki@yahoo.com>
backport: #3310 |
chromedriver@107.0.1
, the last that works on NodeJS v10AbortError
from breaking unit tests for ExecutionContractSigned-off-by: Miki miki@amazon.com
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr