[Backport 2.x] [Dashboard De-Angular] Add unit tests for dashboard_listing and dashboard_top_nav #4761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…oard_top_nav (#4640) * Add unit tests Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix other unit tests and update snapshots Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * update snapshots Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix osdUrlStateStorage Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix snapshots Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> (cherry picked from commit 86a3f1e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla and
seanneumann
as code owners
opensearch-trigger-bot
bot
added
the
needs more info
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested review from
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #4761 +/- ##
==========================================
+ Coverage 66.12% 66.27% +0.15%
==========================================
Files 3315 3319 +4
Lines 63909 63924 +15
Branches 10126 10127 +1
==========================================
+ Hits 42259 42367 +108
+ Misses 19170 19144 -26
+ Partials 2480 2413 -67
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joshuarrrr
approved these changes
Aug 28, 2023
abbyhu2000
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 86a3f1e from #4640.