Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snapshots that didn't get updated between PRs #4863

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

AMoo-Miki
Copy link
Collaborator

2 PRs that passed on their own, interfered with each other's snapshots: #4761 and #4796

This change fixes that.

Signed-off-by: Miki <miki@amazon.com>
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #4863 (316e9c3) into 2.x (95e1359) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x    #4863   +/-   ##
=======================================
  Coverage   66.32%   66.33%           
=======================================
  Files        3321     3321           
  Lines       63897    63897           
  Branches    10112    10112           
=======================================
+ Hits        42382    42384    +2     
+ Misses      19028    19027    -1     
+ Partials     2487     2486    -1     
Flag Coverage Δ
Linux_1 34.86% <ø> (ø)
Linux_2 55.15% <ø> (ø)
Linux_3 43.51% <ø> (?)
Linux_4 35.12% <ø> (ø)
Windows_1 34.87% <ø> (ø)
Windows_2 55.11% <ø> (ø)
Windows_3 43.51% <ø> (ø)
Windows_4 35.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@AMoo-Miki AMoo-Miki merged commit 12eade7 into opensearch-project:2.x Aug 30, 2023
69 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants