[Data Explorer][Discover 2.0] Fix issues when change index pattern #4875

ananzh · 2023-08-31T16:32:44Z

Description

side nav only shows the selected index pattern fields after switch index pattern

allow reset column state when switch index pattern

There are two conditions: 1) If there is common field, common field will be saved.

if no common field, will show _source after switch

Issues Resolved

#4840 #4846

Check List

codecov · 2023-08-31T16:51:09Z

Codecov Report

Merging #4875 (9e23490) into main (b846e80) will decrease coverage by 0.04%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4875      +/-   ##
==========================================
- Coverage   66.42%   66.39%   -0.04%     
==========================================
  Files        3398     3397       -1     
  Lines       64893    64804      -89     
  Branches    10359    10360       +1     
==========================================
- Hits        43108    43028      -80     
+ Misses      19225    19217       -8     
+ Partials     2560     2559       -1

Flag	Coverage Δ
Linux_1	`34.85% <ø> (ø)`
Linux_2	`55.15% <ø> (ø)`
Linux_3	`44.24% <100.00%> (+<0.01%)`	⬆️
Linux_4	`34.92% <ø> (-0.15%)`	⬇️
Windows_1	`34.87% <ø> (ø)`
Windows_2	`55.12% <ø> (ø)`
Windows_3	`44.24% <100.00%> (+<0.01%)`	⬆️
Windows_4	`34.92% <ø> (-0.15%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...pplication/view_components/utils/filter_columns.ts	`100.00% <100.00%> (ø)`

... and 6 files with indirect coverage changes

src/plugins/discover/public/application/components/sidebar/lib/get_index_pattern_field_list.ts

ashwin-pc · 2023-08-31T18:46:56Z

src/plugins/discover/public/application/view_components/utils/filter_columns.ts

+ * Helper function to filter columns based on the fields of the index pattern.
+ * This function is used when we switch between index patterns. We want to keep the columns that are
+ * still available in the new index pattern and remove the ones that are not.
+ * If the resulting array is empty, it provides a fallback to a single '_source' column.


We should use the default column from advanced settings and not hardcode _source. DEFAULT_COLUMNS_SETTING

will update

ashwin-pc · 2023-08-31T18:49:31Z

src/plugins/discover/public/application/view_components/canvas/index.tsx

+  const filteredColumns = filterColumns(columns, indexPattern);
+  const dispatch = useDispatch();
+
+  const prevColumns = useRef(filteredColumns);


Doesn't look like we are using this. Do we need it?

will remove.

* allow side nav show only selected index pattern fields when switch * allow reset column state when switch index pattern Issue Resolve: opensearch-project#4840 opensearch-project#4846 Signed-off-by: ananzh <ananzh@amazon.com>

…4875) * allow side nav show only selected index pattern fields when switch * allow reset column state when switch index pattern Issue Resolve: #4840 #4846 Signed-off-by: ananzh <ananzh@amazon.com> (cherry picked from commit 9958799) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…4875) (#4885) * allow side nav show only selected index pattern fields when switch * allow reset column state when switch index pattern Issue Resolve: #4840 #4846 (cherry picked from commit 9958799) Signed-off-by: ananzh <ananzh@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…ttern (opensearch-project#4875) (opensearch-project#4885)" This reverts commit 0102a32. try revert:

@param

…CH (#5508) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <qiwen_li@brown.edu> * fix deps Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <qiwen_li@brown.edu> --------- Signed-off-by: qiwen li <qiwen_li@brown.edu> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>

@param

…CH (#5508) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <qiwen_li@brown.edu> * fix deps Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <qiwen_li@brown.edu> --------- Signed-off-by: qiwen li <qiwen_li@brown.edu> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 34994f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

@param

…CH (#5508) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <qiwen_li@brown.edu> * fix deps Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <qiwen_li@brown.edu> --------- Signed-off-by: qiwen li <qiwen_li@brown.edu> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 34994f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

@param

…CH (#5508) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <qiwen_li@brown.edu> * fix deps Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <qiwen_li@brown.edu> --------- Signed-off-by: qiwen li <qiwen_li@brown.edu> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 34994f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

@param

…CH (#5508) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <qiwen_li@brown.edu> * fix deps Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <qiwen_li@brown.edu> --------- Signed-off-by: qiwen li <qiwen_li@brown.edu> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 34994f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

@param

…CH (#5508) (#5746) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <qiwen_li@brown.edu> * fix deps Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <qiwen_li@brown.edu> --------- Signed-off-by: qiwen li <qiwen_li@brown.edu> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 34994f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

@param

…CH (#5508) (#5638) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <qiwen_li@brown.edu> * fix deps Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <qiwen_li@brown.edu> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <qiwen_li@brown.edu> --------- Signed-off-by: qiwen li <qiwen_li@brown.edu> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 34994f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

ananzh requested review from kavilla, seanneumann, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, kristenTian, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, BSFishy and curq as code owners August 31, 2023 16:32

ananzh assigned ananzh and ashwin-pc Aug 31, 2023

ananzh added discover for discover reinvent data explorer Issues related to the Data Explorer project v2.10.0 labels Aug 31, 2023

github-actions bot added the distinguished-contributor label Aug 31, 2023

ananzh added the backport 2.x label Aug 31, 2023

ananzh added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Aug 31, 2023

ashwin-pc reviewed Aug 31, 2023

View reviewed changes

ananzh force-pushed the discover-fix-change-idx branch from 1eaf649 to 16b5cf8 Compare August 31, 2023 19:21

ananzh force-pushed the discover-fix-change-idx branch from 16b5cf8 to 9e23490 Compare August 31, 2023 19:26

ashwin-pc approved these changes Aug 31, 2023

View reviewed changes

abbyhu2000 approved these changes Aug 31, 2023

View reviewed changes

ashwin-pc merged commit 9958799 into opensearch-project:main Aug 31, 2023
54 checks passed

opensearch-trigger-bot bot mentioned this pull request Aug 31, 2023

[Backport 2.x] [Data Explorer][Discover 2.0] Fix issues when change index pattern #4885

Merged

MadaniKK added a commit to MadaniKK/OpenSearch-Dashboards that referenced this pull request Nov 18, 2023

Revert "[Data Explorer][Discover 2.0] Fix issues when change index pa…

9f7d04a

…ttern (opensearch-project#4875) (opensearch-project#4885)" This reverts commit 0102a32. try revert:

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Data Explorer][Discover 2.0] Fix issues when change index pattern #4875

[Data Explorer][Discover 2.0] Fix issues when change index pattern #4875

ananzh commented Aug 31, 2023

codecov bot commented Aug 31, 2023 •

edited

Loading

ashwin-pc Aug 31, 2023

ananzh Aug 31, 2023

ashwin-pc Aug 31, 2023

ananzh Aug 31, 2023

[Data Explorer][Discover 2.0] Fix issues when change index pattern #4875

[Data Explorer][Discover 2.0] Fix issues when change index pattern #4875

Conversation

ananzh commented Aug 31, 2023

Description

Issues Resolved

Check List

codecov bot commented Aug 31, 2023 • edited Loading

Codecov Report

ashwin-pc Aug 31, 2023

Choose a reason for hiding this comment

ananzh Aug 31, 2023

Choose a reason for hiding this comment

ashwin-pc Aug 31, 2023

Choose a reason for hiding this comment

ananzh Aug 31, 2023

Choose a reason for hiding this comment

codecov bot commented Aug 31, 2023 •

edited

Loading